Remove read_file.h #4912
Merged
Remove read_file.h #4912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4912
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e1608d3 with merge base d9ae7c3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61749168 |
jackzhxng
approved these changes
Aug 26, 2024
|
This pull request was exported from Phabricator. Differential Revision: D61749168 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Aug 26, 2024
Summary: Pull Request resolved: pytorch#4912 ExecuTorch shouldn't be in the business of providing file-reading helpers to clients. There are plenty of other libraries that can do this. Remove the final references to this header, and delete the header and its target. Reviewed By: dvorjackz Differential Revision: D61749168
dbort
force-pushed
the
export-D61749168
branch
from
f712e4f to
60cbd48
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61749168 |
dbort
force-pushed
the
export-D61749168
branch
from
60cbd48 to
7539189
Compare
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Aug 27, 2024
Summary: Pull Request resolved: pytorch#4912 ExecuTorch shouldn't be in the business of providing file-reading helpers to clients. There are plenty of other libraries that can do this. Remove the final references to this header, and delete the header and its target. Reviewed By: dvorjackz Differential Revision: D61749168
Summary: Pull Request resolved: pytorch#4912 ExecuTorch shouldn't be in the business of providing file-reading helpers to clients. There are plenty of other libraries that can do this. Remove the final references to this header, and delete the header and its target. Reviewed By: dvorjackz Differential Revision: D61749168
|
This pull request was exported from Phabricator. Differential Revision: D61749168 |
dbort
force-pushed
the
export-D61749168
branch
from
7539189 to
e1608d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ExecuTorch shouldn't be in the business of providing file-reading helpers to clients. There are plenty of other libraries that can do this.
Remove the final references to this header, and delete the header and its target.
Reviewed By: dvorjackz
Differential Revision: D61749168