Fix the key used for extraction of delegate debug handle map in emitter #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for resplendent-gnome-14e531 canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D49620440 |
|
This pull request was exported from Phabricator. Differential Revision: D49620440 |
tarun292
force-pushed
the
export-D49620440
branch
from
c31054c to
00c6b83
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49620440 |
tarun292
force-pushed
the
export-D49620440
branch
from
00c6b83 to
be4ec79
Compare
Differential Revision: D48993977 fbshipit-source-id: 89550d0139f3132cef2a2843301760b993079631
Differential Revision: D48975977 fbshipit-source-id: 24f8efd196959fbe74535530c8d299d7ab557771
Differential Revision: D49652299 fbshipit-source-id: c986cc32c8171b9c81aaffc99315fd906f1ecad4
…er (#493) Summary: Pull Request resolved: pytorch/executorch#493 In D49173918 while looking for the delegate map in the lowered_module metadata i ended up using the wrong key. It should be `debug_handle_map` and not `delegate_map`. Reviewed By: Jack-Khuu Differential Revision: D49620440 fbshipit-source-id: c7fda016580d8deaf8c36968c53867a1379320e8
|
This pull request was exported from Phabricator. Differential Revision: D49620440 |
tarun292
force-pushed
the
export-D49620440
branch
from
be4ec79 to
1854f4a
Compare
|
This pull request has been merged in 8cbfa80. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In D49173918 while looking for the delegate map in the lowered_module metadata i ended up using the wrong key. It should be
debug_handle_mapand notdelegate_map.Reviewed By: Jack-Khuu
Differential Revision: D49620440