Skip to content

Move threadpool to extension #4954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

kirklandsign
Copy link
Contributor

Summary:

  1. Replace executorch/backends/xnnpack/threadpool with executorch/extension/threadpool
  2. hg mv xplat/executorch/backends/xnnpack/threadpool xplat/executorch/extension and hg mv fbcode/executorch/backends/xnnpack/threadpool fbcode/executorch/extension

Differential Revision: D61938189

Copy link

pytorch-bot bot commented Aug 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4954

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9a2cd3e with merge base 1899d15 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61938189

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61938189

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61938189

kirklandsign added a commit to kirklandsign/executorch that referenced this pull request Aug 28, 2024
Summary:
Pull Request resolved: pytorch#4954

1. Replace `executorch/backends/xnnpack/threadpool` with `executorch/extension/threadpool` Need to exclude `whatsapp/`
2. `hg mv xplat/executorch/backends/xnnpack/threadpool xplat/executorch/extension` and `hg mv fbcode/executorch/backends/xnnpack/threadpool fbcode/executorch/extension`

Differential Revision: D61938189
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61938189

kirklandsign added a commit to kirklandsign/executorch that referenced this pull request Aug 28, 2024
Summary:
Pull Request resolved: pytorch#4954

1. Replace `executorch/backends/xnnpack/threadpool` with `executorch/extension/threadpool` Need to exclude `whatsapp/`
2. `hg mv xplat/executorch/backends/xnnpack/threadpool xplat/executorch/extension` and `hg mv fbcode/executorch/backends/xnnpack/threadpool fbcode/executorch/extension`

Differential Revision: D61938189
Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kimishpatel should take a look

Summary:
Pull Request resolved: pytorch#4954

1. Replace `executorch/backends/xnnpack/threadpool` with `executorch/extension/threadpool` Need to exclude `whatsapp/`
2. `hg mv xplat/executorch/backends/xnnpack/threadpool xplat/executorch/extension` and `hg mv fbcode/executorch/backends/xnnpack/threadpool fbcode/executorch/extension`

Reviewed By: larryliu0820

Differential Revision: D61938189
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61938189

@facebook-github-bot facebook-github-bot merged commit 89ebeb0 into pytorch:main Aug 29, 2024
40 of 43 checks passed
@kirklandsign kirklandsign deleted the export-D61938189 branch August 29, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants