Skip to content

Use a separate threadpool library #4967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 30, 2024
Merged

Use a separate threadpool library #4967

merged 13 commits into from
Aug 30, 2024

Conversation

kirklandsign
Copy link
Contributor

Differential Revision: D61940492

@kirklandsign @facebook-github-bot
Use a separate threadpool library
9ea1202 
Differential Revision: D61940492
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 29, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4967

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9152da0 with merge base 0c6a77e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 29, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61940492

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kirklandsign
Copy link
Contributor Author

kirklandsign commented Aug 29, 2024 •
edited
Loading

ExecuTorch with no ops binary size, unstripped:
-rwxr-xr-x 1 hsz users 70080 Aug 29 00:23 cmake-out/test/size_test
ExecuTorch with portable ops binary size, unstripped:
-rwxr-xr-x 1 hsz users 10324472 Aug 29 00:23 cmake-out/test/size_test_all_ops
(executorch) executorch $ strip cmake-out/test/size_test
(executorch) executorch $ ls -al cmake-out/test/size_test
-rwxr-xr-x 1 hsz users 48120 Aug 29 00:24 cmake-out/test/size_test

@kirklandsign
Copy link
Contributor Author

Seems that size is reduced?

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit cd8aed6 into pytorch:main Aug 30, 2024
41 of 43 checks passed
@kirklandsign kirklandsign deleted the export-D61940492 branch September 4, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirklandsign @facebook-github-bot @larryliu0820