[ExecuTorch] support BF16 in LLM runner & sampler #4984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfloat16.h was a stub. I've filled it out by porting the c10 implementation, added it to ET_SWITCH and ET_FORALL macros, and hooked it up to promoteTypes. I extended the half_to_float argument to promoteTypes to also coerce bfloat16 to float because I figured anybody who wants to ignore half probably also wants to ignore bf16. Differential Revision: [D61981361](https://our.internmc.facebook.com/intern/diff/D61981361/) [ghstack-poisoned]
Adding bfloat16 support to important ops for LLMs to start. Differential Revision: [D61981356](https://our.internmc.facebook.com/intern/diff/D61981356/) [ghstack-poisoned]
Adding bfloat16 support to important ops for LLMs to start. Differential Revision: [D61981355](https://our.internmc.facebook.com/intern/diff/D61981355/) [ghstack-poisoned]
Adding bfloat16 support to important ops for LLMs to start. Differential Revision: [D61981353](https://our.internmc.facebook.com/intern/diff/D61981353/) [ghstack-poisoned]
Adding bfloat16 support to important ops for LLMs to start. Differential Revision: [D61981357](https://our.internmc.facebook.com/intern/diff/D61981357/) [ghstack-poisoned]
Adding bfloat16 support to important ops for LLMs to start. Differential Revision: [D61981364](https://our.internmc.facebook.com/intern/diff/D61981364/) [ghstack-poisoned]
Adding bfloat16 support to important ops for LLMs to start. Differential Revision: [D61981360](https://our.internmc.facebook.com/intern/diff/D61981360/) [ghstack-poisoned]
Adding bfloat16 support to important ops for LLMs to start. Differential Revision: [D61981359](https://our.internmc.facebook.com/intern/diff/D61981359/) [ghstack-poisoned]
Adding bfloat16 support to important ops for LLMs to start. Differential Revision: [D61981362](https://our.internmc.facebook.com/intern/diff/D61981362/) [ghstack-poisoned]
The LLM runner assumed that the data type could only be float or half. Suport bfloat16 and neaten up the code while we're at it. Differential Revision: [D61981354](https://our.internmc.facebook.com/intern/diff/D61981354/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D61981354/)! [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4984
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Cancelled Job, 1 Unrelated FailureAs of commit bdb184b with merge base 3c58237 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61981354 |
This was referenced Aug 29, 2024
This was referenced Aug 29, 2024
digantdesai
approved these changes
Aug 29, 2024
…sampler" The LLM runner assumed that the data type could only be float or half. Suport bfloat16 and neaten up the code while we're at it. Differential Revision: [D61981354](https://our.internmc.facebook.com/intern/diff/D61981354/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D61981354/)! [ghstack-poisoned]
The LLM runner assumed that the data type could only be float or half. Suport bfloat16 and neaten up the code while we're at it. Differential Revision: [D61981354](https://our.internmc.facebook.com/intern/diff/D61981354/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D61981354/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D61981354 |
swolchok
changed the base branch from
gh/swolchok/29/base
to
gh/swolchok/28/head
…sampler" The LLM runner assumed that the data type could only be float or half. Suport bfloat16 and neaten up the code while we're at it. Differential Revision: [D61981354](https://our.internmc.facebook.com/intern/diff/D61981354/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D61981354/)! [ghstack-poisoned]
The LLM runner assumed that the data type could only be float or half. Suport bfloat16 and neaten up the code while we're at it. Differential Revision: [D61981354](https://our.internmc.facebook.com/intern/diff/D61981354/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D61981354/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D61981354 |
…sampler" The LLM runner assumed that the data type could only be float or half. Suport bfloat16 and neaten up the code while we're at it. Differential Revision: [D61981354](https://our.internmc.facebook.com/intern/diff/D61981354/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D61981354/)! [ghstack-poisoned]
The LLM runner assumed that the data type could only be float or half. Suport bfloat16 and neaten up the code while we're at it. Differential Revision: [D61981354](https://our.internmc.facebook.com/intern/diff/D61981354/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D61981354/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D61981354 |
…sampler" The LLM runner assumed that the data type could only be float or half. Suport bfloat16 and neaten up the code while we're at it. Differential Revision: [D61981354](https://our.internmc.facebook.com/intern/diff/D61981354/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D61981354/)! [ghstack-poisoned]
The LLM runner assumed that the data type could only be float or half. Suport bfloat16 and neaten up the code while we're at it. Differential Revision: [D61981354](https://our.internmc.facebook.com/intern/diff/D61981354/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D61981354/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D61981354 |
…sampler" The LLM runner assumed that the data type could only be float or half. Suport bfloat16 and neaten up the code while we're at it. Differential Revision: [D61981354](https://our.internmc.facebook.com/intern/diff/D61981354/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D61981354/)! [ghstack-poisoned]
The LLM runner assumed that the data type could only be float or half. Suport bfloat16 and neaten up the code while we're at it. Differential Revision: [D61981354](https://our.internmc.facebook.com/intern/diff/D61981354/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D61981354/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D61981354 |
…sampler" The LLM runner assumed that the data type could only be float or half. Suport bfloat16 and neaten up the code while we're at it. Differential Revision: [D61981354](https://our.internmc.facebook.com/intern/diff/D61981354/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D61981354/)! [ghstack-poisoned]
The LLM runner assumed that the data type could only be float or half. Suport bfloat16 and neaten up the code while we're at it. Differential Revision: [D61981354](https://our.internmc.facebook.com/intern/diff/D61981354/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D61981354/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D61981354 |
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The LLM runner assumed that the data type could only be float or half. Suport bfloat16 and neaten up the code while we're at it.
Differential Revision: D61981354
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!