Skip to content

Preprocess C++ #4987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Preprocess C++ #4987

merged 1 commit into from
Aug 30, 2024

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Aug 29, 2024

Summary:
Preprocess C++ runner calculations.

Mirror torchtune's helper functions in C++, and tests

  • find_supported_resolutions
  • get_canvas_best_fit
  • get_inscribed_size

Functions: https://github.com/pytorch/torchtune/tree/main/torchtune/modules/transforms/vision_utils

Reviewed By: mergennachin

Differential Revision: D61833480

Copy link

pytorch-bot bot commented Aug 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4987

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f2d0cc8 with merge base 12039af (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 29, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61833480

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Aug 29, 2024
Summary:

Preprocess C++ runner calculations.

Mirror torchtune's helper functions in C++, and tests

- find_supported_resolutions
- get_canvas_best_fit
- get_inscribed_size

Functions: https://github.com/pytorch/torchtune/tree/main/torchtune/modules/transforms/vision_utils

Reviewed By: mergennachin

Differential Revision: D61833480
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61833480

Summary:

Preprocess C++ runner calculations.

Mirror torchtune's helper functions in C++, and tests

- find_supported_resolutions
- get_canvas_best_fit
- get_inscribed_size

Functions: https://github.com/pytorch/torchtune/tree/main/torchtune/modules/transforms/vision_utils

Reviewed By: mergennachin

Differential Revision: D61833480
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61833480

@facebook-github-bot facebook-github-bot merged commit 1263964 into pytorch:main Aug 30, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants