[executorch] Add logs for helping debug address space overflow issue #5035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5035
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b10de68 with merge base 9fafdb0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jackzhxng
force-pushed
the
jackxz/memory-planning-hint
branch
from
9d62254 to
8890150
Compare
JacobSzwejbka
approved these changes
Sep 3, 2024
|
@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add logs to help debug offset calculated by memory planning being larger than 64 bits.
Test plan
Reproduced
to_executorchissue described in pytorch/pytorch#134899 and verified exception logs.