Remove extract_constant_segment from config #5096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5096
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 8085cea with merge base 5f4a811 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61996249 |
|
This pull request was exported from Phabricator. Differential Revision: D61996249 |
lucylq
force-pushed
the
export-D61996249
branch
from
60aec22 to
0d181d4
Compare
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 5, 2024
Summary: Pull Request resolved: pytorch#5096 All usages of extract_constant_segment should be removed. Update program and method tests, and update test artifacts to only generate .pte with constant segment. Differential Revision: D61996249
|
This pull request was exported from Phabricator. Differential Revision: D61996249 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 5, 2024
Summary: Pull Request resolved: pytorch#5096 All usages of extract_constant_segment should be removed. Update program and method tests, and update test artifacts to only generate .pte with constant segment. Differential Revision: D61996249
lucylq
force-pushed
the
export-D61996249
branch
from
0d181d4 to
c2342b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61996249 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 5, 2024
Summary: Pull Request resolved: pytorch#5096 All usages of extract_constant_segment should be removed. Update program and method tests, and update test artifacts to only generate .pte with constant segment. Differential Revision: D61996249
lucylq
force-pushed
the
export-D61996249
branch
from
c2342b7 to
484fb84
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61996249 |
lucylq
force-pushed
the
export-D61996249
branch
from
484fb84 to
685424d
Compare
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 5, 2024
Summary: Pull Request resolved: pytorch#5096 All usages of extract_constant_segment should be removed. Update program and method tests, and update test artifacts to only generate .pte with constant segment. Add test/models/deprecated/ containing - readme - .pte file with deprecated constant_buffer feature. Differential Revision: D61996249
|
This pull request was exported from Phabricator. Differential Revision: D61996249 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 5, 2024
Summary: Pull Request resolved: pytorch#5096 All usages of extract_constant_segment should be removed. Update program and method tests, and update test artifacts to only generate .pte with constant segment. Add test/models/deprecated/ containing - readme - .pte file with deprecated constant_buffer feature. Differential Revision: D61996249
lucylq
force-pushed
the
export-D61996249
branch
from
685424d to
d018611
Compare
dbort
approved these changes
Sep 5, 2024
|
This pull request was exported from Phabricator. Differential Revision: D61996249 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 6, 2024
Summary: Pull Request resolved: pytorch#5096 All usages of extract_constant_segment should be removed. Update program and method tests, and update test artifacts to only generate .pte with constant segment. Add test/models/deprecated/ containing - readme - .pte file with deprecated constant_buffer feature. Reviewed By: dbort Differential Revision: D61996249
lucylq
force-pushed
the
export-D61996249
branch
from
d018611 to
4ecfd2a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61996249 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 6, 2024
Summary: Pull Request resolved: pytorch#5096 All usages of extract_constant_segment should be removed. Update program and method tests, and update test artifacts to only generate .pte with constant segment. Add test/models/deprecated/ containing - readme - .pte file with deprecated constant_buffer feature. Reviewed By: dbort Differential Revision: D61996249
lucylq
force-pushed
the
export-D61996249
branch
from
4ecfd2a to
6700e71
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61996249 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 6, 2024
Summary: Pull Request resolved: pytorch#5096 All usages of extract_constant_segment should be removed. Update program and method tests, and update test artifacts to only generate .pte with constant segment. Add test/models/deprecated/ containing - readme - .pte file with deprecated constant_buffer feature. Reviewed By: dbort Differential Revision: D61996249
lucylq
force-pushed
the
export-D61996249
branch
from
6700e71 to
373f080
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61996249 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 6, 2024
Summary: Pull Request resolved: pytorch#5096 All usages of extract_constant_segment should be removed. Update program and method tests, and update test artifacts to only generate .pte with constant segment. Add test/models/deprecated/ containing - readme - .pte file with deprecated constant_buffer feature. Reviewed By: dbort Differential Revision: D61996249
lucylq
force-pushed
the
export-D61996249
branch
from
373f080 to
9314951
Compare
Summary: Pull Request resolved: pytorch#5096 All usages of extract_constant_segment should be removed. Update program and method tests, and update test artifacts to only generate .pte with constant segment. Add test/models/deprecated/ containing - readme - .pte file with deprecated constant_buffer feature. Reviewed By: dbort Differential Revision: D61996249
|
This pull request was exported from Phabricator. Differential Revision: D61996249 |
lucylq
force-pushed
the
export-D61996249
branch
from
9314951 to
8085cea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
All usages of extract_constant_segment should be removed.
Update program and method tests, and update test artifacts to only generate .pte with constant segment.
Differential Revision: D61996249