[ET-VK] Fix negative dim in normalize_to_dim_index
#5118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our `cat` implementation currently fails for negative dim. Differential Revision: [D62270925](https://our.internmc.facebook.com/intern/diff/D62270925/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5118
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8b63ea8 with merge base 83d92ff ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jorgep31415
added a commit
that referenced
this pull request
Sep 5, 2024
Our `cat` implementation currently fails for negative dim. Differential Revision: [D62270925](https://our.internmc.facebook.com/intern/diff/D62270925/) ghstack-source-id: 241265784 Pull Request resolved: #5118
|
This pull request was exported from Phabricator. Differential Revision: D62270925 |
nathanaelsee
approved these changes
Sep 5, 2024
yipjustin
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
normalize_to_dim_index#5118Our
catimplementation currently fails for negative dim.Differential Revision: D62270925