Skip to content

Make convert to linear an export pass #5133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

mcr229
Copy link
Contributor

@mcr229 mcr229 commented Sep 6, 2024

Summary: Let's remove the reliance on export pass from convert to linear pass. This allows us. We only use exported program in one place to find the bias.

Differential Revision: D62266927

Copy link

pytorch-bot bot commented Sep 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5133

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b513ebc with merge base 99fbca3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 6, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62266927

Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

propagating internal accept to github

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62266927

mcr229 added a commit to mcr229/executorch that referenced this pull request Sep 9, 2024
Summary:
Pull Request resolved: pytorch#5133

Let's remove the reliance on export pass from convert to linear pass. This allows us. We only use exported program in one place to find the bias.

Reviewed By: digantdesai

Differential Revision: D62266927
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62266927

mcr229 added a commit to mcr229/executorch that referenced this pull request Sep 9, 2024
Summary:
Pull Request resolved: pytorch#5133

Let's remove the reliance on export pass from convert to linear pass. This allows us. We only use exported program in one place to find the bias.

Reviewed By: digantdesai

Differential Revision: D62266927
Summary:
Pull Request resolved: pytorch#5133

Let's remove the reliance on export pass from convert to linear pass. This allows us. We only use exported program in one place to find the bias.

Reviewed By: digantdesai

Differential Revision: D62266927
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62266927

@facebook-github-bot facebook-github-bot merged commit cd9d536 into pytorch:main Sep 9, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants