[ExecuTorch] Handle rank 0 tensors correctly in optimized add/sub/div/mul #5140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/mul We didn't handle this possibility correctly. Differential Revision: [D62310838](https://our.internmc.facebook.com/intern/diff/D62310838/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5140
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fe14f3c with merge base 2863536 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Sep 6, 2024
…/mul We didn't handle this possibility correctly. Differential Revision: [D62310838](https://our.internmc.facebook.com/intern/diff/D62310838/) ghstack-source-id: 241401327 Pull Request resolved: #5140
|
This pull request was exported from Phabricator. Differential Revision: D62310838 |
…add/sub/div/mul" We didn't handle this possibility correctly. Differential Revision: [D62310838](https://our.internmc.facebook.com/intern/diff/D62310838/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D62310838 |
swolchok
added a commit
that referenced
this pull request
Sep 6, 2024
…/mul Pull Request resolved: #5140 We didn't handle this possibility correctly. Differential Revision: [D62310838](https://our.internmc.facebook.com/intern/diff/D62310838/) ghstack-source-id: 241416185
|
Please set the merge base to |
kirklandsign
approved these changes
Sep 6, 2024
kirklandsign
approved these changes
Sep 6, 2024
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
We didn't handle this possibility correctly.
Differential Revision: D62310838