Skip to content

Qualcomm AI Engine Direct - Uplevel QNN version for ci test #5174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shewu-quic
Copy link
Collaborator

Summary:

  • For rms norm, we need to uplevel to QNN sdk 2.25 or above
  • There is no libc++.so in ${QNN_SDK_ROOT}/lib/x86_64-linux-clang for QNN sdk 2.23 or above.
    So, we need to install it manually.

Copy link

pytorch-bot bot commented Sep 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5174

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 69bfaea with merge base 59d9bad (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2024
@shewu-quic shewu-quic force-pushed the dev1/hutton/restore_qnn_llama_ci_test branch from a9dd877 to 9254705 Compare September 9, 2024 08:03
@shewu-quic shewu-quic marked this pull request as draft September 9, 2024 08:04
@shewu-quic shewu-quic force-pushed the dev1/hutton/restore_qnn_llama_ci_test branch 2 times, most recently from 4bae155 to d164cd4 Compare September 9, 2024 08:55
@shewu-quic shewu-quic marked this pull request as ready for review September 9, 2024 09:14
@shewu-quic
Copy link
Collaborator Author

shewu-quic commented Sep 9, 2024

Hi @cccclai,

This PR is to install a libc++.so and uplevel qnn.
Once PR #5072 is merged, could you help to review it?

Thanks a lot.

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat. Thank you!

Summary:
- For rms norm, we need to uplevel to QNN sdk 2.25 or above
- There is no libc++.so in ${QNN_SDK_ROOT}/lib/x86_64-linux-clang for QNN
sdk 2.23 or above.
So, we need to install it manually.
@shewu-quic shewu-quic force-pushed the dev1/hutton/restore_qnn_llama_ci_test branch from d164cd4 to 69bfaea Compare September 9, 2024 23:44
@cccclai cccclai merged commit f412630 into pytorch:main Sep 10, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants