Use c++17 for size test #5178
Merged
Use c++17 for size test #5178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5178
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e43f454 with merge base cd9d536 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62389344 |
|
This pull request was exported from Phabricator. Differential Revision: D62389344 |
lucylq
force-pushed
the
export-D62389344
branch
from
94b7605 to
c088eb9
Compare
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 9, 2024
Summary: Pull Request resolved: pytorch#5178 Revert the changes in: D57003591: use C++11 for size test D56834619: use C++14 for size test Differential Revision: D62389344
dbort
approved these changes
Sep 9, 2024
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 9, 2024
Summary: Pull Request resolved: pytorch#5178 Revert the changes in: D57003591: use C++11 for size test D56834619: use C++14 for size test Reviewed By: dbort Differential Revision: D62389344
lucylq
force-pushed
the
export-D62389344
branch
from
c088eb9 to
eaaf0da
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62389344 |
Summary: Pull Request resolved: pytorch#5178 Revert the changes in: D57003591: use C++11 for size test D56834619: use C++14 for size test Reviewed By: dbort Differential Revision: D62389344
|
This pull request was exported from Phabricator. Differential Revision: D62389344 |
lucylq
force-pushed
the
export-D62389344
branch
from
eaaf0da to
e43f454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Revert the changes in:
D57003591: use C++11 for size test
D56834619: use C++14 for size test
Differential Revision: D62389344