Update schema to include infinity for double values #5203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5203
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ac31049 with merge base 7650667 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62393242 |
|
This pull request was exported from Phabricator. Differential Revision: D62393242 |
lucylq
force-pushed
the
export-D62393242
branch
from
5db96fb to
0f92498
Compare
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 10, 2024
Summary: Pull Request resolved: pytorch#5203 Replace previous solution of parsing the json and replacing instances of "Infinity" with "inf" Differential Revision: D62393242
|
This pull request was exported from Phabricator. Differential Revision: D62393242 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 10, 2024
Summary: Pull Request resolved: pytorch#5203 Replace previous solution of parsing the json and replacing instances of "Infinity" with "inf" Differential Revision: D62393242
lucylq
force-pushed
the
export-D62393242
branch
from
0f92498 to
bb69dab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62393242 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 10, 2024
Summary: Pull Request resolved: pytorch#5203 Replace previous solution of parsing the json and replacing instances of "Infinity" with "inf" Deserialization process: 1. Convert flatbuffer to json, using program.fbs. Program.fbs doesn't have the Union double type (only schema.py); use regex to replace instances of `-inf` to `"-inf"`. 2. Convert json to dataclasses. Add support for Union double type here. Differential Revision: D62393242
lucylq
force-pushed
the
export-D62393242
branch
2 times, most recently
from
ed081c0 to
fd48e5e
Compare
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 10, 2024
Summary: Pull Request resolved: pytorch#5203 Replace previous solution of parsing the json and replacing instances of "Infinity" with "inf" Serialization: 1. Program is created using schema.py dataclasses in emitter. Add default constructors (`__init__`), so that all constructions of Double are either float, or string for infinity values. Deserialization process: 1. Convert flatbuffer to json, using program.fbs. Program.fbs doesn't have the Union double type (only schema.py); use regex to replace instances of `-inf` to `"-inf"`. 2. Convert json to dataclasses. Add support for Union double type here. Differential Revision: D62393242
|
This pull request was exported from Phabricator. Differential Revision: D62393242 |
Summary: Pull Request resolved: pytorch#5203 Replace previous solution of parsing the json and replacing instances of "Infinity" with "inf" Serialization: 1. Python dataclasses --> JSON --> flatbuffer. 2. Convert Double inside schema.py to a union value of float and string, so that there is valid JSON when we convert dataclasses --> JSON. 2. Program is created using schema.py dataclasses in emitter. Add default constructors (`__init__`), so that all constructions of Double are either float, or string for infinity values. 3. Note: `program.fbs` remains unchanged. Deserialization process: 1. Flatbuffer --> JSON --> python dataclasses. 2. Flatbuffer is converted to JSON using `program.fbs`, which does not have the Union double definition. Use regex to replace instances of `-inf` to `"-inf"` so that there is valid JSON. 3. Add support for Union double type for the conversion from JSON to python dataclasses Differential Revision: D62393242
|
This pull request was exported from Phabricator. Differential Revision: D62393242 |
lucylq
force-pushed
the
export-D62393242
branch
from
fd48e5e to
ac31049
Compare
dbort
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Replace previous solution of parsing the json and replacing instances of "Infinity" with "inf"
Differential Revision: D62393242