Let the app check "aatp/data" subdir for AWS. #5208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5208
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 7213080 with merge base 63e794a ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62409615 |
|
This pull request was exported from Phabricator. Differential Revision: D62409615 |
huydhn
approved these changes
Sep 10, 2024
guangy10
approved these changes
Sep 10, 2024
|
This pull request was exported from Phabricator. Differential Revision: D62409615 |
Summary: Pull Request resolved: #5208 Also handle same model name in multiple directories. Also, use separate build flags for debug and release. Reviewed By: huydhn, guangy10 Differential Revision: D62409615
|
This pull request was exported from Phabricator. Differential Revision: D62409615 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
…pp (#5212) Summary: This requires shoumikhin change in #5208, so I will rebase and test it out again after #5208 lands ### Testing https://github.com/pytorch/executorch/actions/runs/10787058020 Reviewed By: shoumikhin, guangy10 Differential Revision: D62415898 Pulled By: huydhn
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
…pp (#5212) Summary: This requires shoumikhin change in #5208, so I will rebase and test it out again after #5208 lands ### Testing https://github.com/pytorch/executorch/actions/runs/10787058020 Reviewed By: shoumikhin, guangy10 Differential Revision: D62415898 Pulled By: huydhn
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
…pp (#5212) Summary: This requires shoumikhin change in #5208, so I will rebase and test it out again after #5208 lands ### Testing https://github.com/pytorch/executorch/actions/runs/10787058020 Pull Request resolved: #5212 Reviewed By: shoumikhin, guangy10 Differential Revision: D62415898 Pulled By: huydhn fbshipit-source-id: 16aeb94e01519c48d75666454e4db933151dc650
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Also handle same model name in multiple directories. Also, use separate build flags for debug and release.
Differential Revision: D62409615