[ExecuTorch] Precompute multiplicative inverse when possible in op_div #5209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Division is generally slower than multiplication in hardware. Differential Revision: [D62412539](https://our.internmc.facebook.com/intern/diff/D62412539/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5209
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit dc9b241 with merge base 6328d41 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62412539 |
swolchok
added a commit
that referenced
this pull request
Sep 9, 2024
Division is generally slower than multiplication in hardware. Differential Revision: [D62412539](https://our.internmc.facebook.com/intern/diff/D62412539/) ghstack-source-id: 241724637 Pull Request resolved: #5209
swolchok
requested review from
kirklandsign,
kimishpatel,
lucylq and
manuelcandales
…le in op_div" Division is generally slower than multiplication in hardware. Differential Revision: [D62412539](https://our.internmc.facebook.com/intern/diff/D62412539/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D62412539 |
swolchok
added a commit
that referenced
this pull request
Sep 12, 2024
Pull Request resolved: #5209 Division is generally slower than multiplication in hardware. Differential Revision: [D62412539](https://our.internmc.facebook.com/intern/diff/D62412539/) ghstack-source-id: 242226478
kimishpatel
approved these changes
Sep 13, 2024
|
This pull request has been merged in 07e15a9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Division is generally slower than multiplication in hardware.
Differential Revision: D62412539