Remove references to exec_aten::RuntimeContext #5257
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5257
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f3ec544 with merge base 75a56a2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62478758 |
|
This pull request was exported from Phabricator. Differential Revision: D62478758 |
dbort
force-pushed
the
export-D62478758
branch
from
58b6096 to
3715b99
Compare
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 11, 2024
Summary: Pull Request resolved: pytorch#5257 RuntimeContext should never have been in that namespace since it's not an ATen type. There are still other internal users outside of //executorch, but the important thing right now is that we set good examples for OSS users. Differential Revision: D62478758
Summary: Pull Request resolved: pytorch#5257 RuntimeContext should never have been in that namespace since it's not an ATen type. There are still other internal users outside of //executorch, but the important thing right now is that we set good examples for OSS users. Differential Revision: D62478758
|
This pull request was exported from Phabricator. Differential Revision: D62478758 |
dbort
force-pushed
the
export-D62478758
branch
from
3715b99 to
f3ec544
Compare
manuelcandales
approved these changes
Sep 11, 2024
|
This pull request has been merged in 7e3ec96. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
RuntimeContext should never have been in that namespace since it's not an ATen type.
There are still other internal users outside of //executorch, but the important thing right now is that we set good examples for OSS users.
Differential Revision: D62478758