Just print Android instrument log when the test passes #5280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5280
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ee2fb49 with merge base 6328d41 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kirklandsign
approved these changes
Sep 11, 2024
Summary: This should make it easier to reuse the test spec on Minibench where we don't need to rely on instrument tests to run the benchmark anymore while just keeping it to satisfy AWS as one of its required input. Reviewed By: kirklandsign Differential Revision: D62521107 Pulled By: huydhn
facebook-github-bot
force-pushed
the
update-android-spec-parsing-rule
branch
from
aa14e5c to
ee2fb49
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62521107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to reuse the test spec on Minibench where we don't need to rely on instrument tests to run the benchmark anymore while just keeping it to satisfy AWS as one of its required input.