Skip to content

Increase timeout threshold for on-device benchmarking #5324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Increase timeout threshold for on-device benchmarking #5324

wants to merge 1 commit into from

Conversation

guangy10
Copy link
Contributor

Seeing timeout issue in iOS workflow due to queueing/scheduling. We will increase the timeout threshold to 120mins (from 60mins).

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 12, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5324

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1dc2f9d with merge base 25168b7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2024
@guangy10 guangy10 requested a review from huydhn September 12, 2024 21:32
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 force-pushed the increase_benchinfra_timeout_threshold branch from ca61a45 to 40b4648 Compare September 13, 2024 18:23
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 force-pushed the increase_benchinfra_timeout_threshold branch from 40b4648 to ca1ef43 Compare September 13, 2024 20:38
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 force-pushed the increase_benchinfra_timeout_threshold branch from ca1ef43 to 1dc2f9d Compare September 13, 2024 22:19
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@guangy10 merged this pull request in 9b5ba1f.

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 2001b3c.

@guangy10 guangy10 deleted the increase_benchinfra_timeout_threshold branch September 14, 2024 00:32
@guangy10
Copy link
Contributor Author

Re-land in #5371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

@kirklandsign kirklandsign kirklandsign approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guangy10 @facebook-github-bot @huydhn @kirklandsign