Skip to content

Update iOS Llama demo app readme docs #5359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Riandy
Copy link
Contributor

@Riandy Riandy commented Sep 13, 2024

Summary:

  • Revamp and standardize the readme docs structure for better clarity.
  • Added different delegate instructions for ios.
  • Added some screenshots to improve readme clarity.

Differential Revision: D62660106

Copy link

pytorch-bot bot commented Sep 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5359

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 3b3871f with merge base e0c9312 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62660106

Export the model
```
python -m examples.models.llama2.export_llama --checkpoint <consolidated.00.pth> -p <params.json> -kv --use_sdpa_with_kv_cache -X -qmode 8da4w --group_size 128 -d fp32 --metadata '{"get_bos_id":128000, "get_eos_ids":[128009, 128001]}' --embedding-quantize 4,32 --output_name="llama3_kv_sdpa_xnn_qe_4_32.pte"
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have instructions on how to export Llava?

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62660106

Riandy added a commit to Riandy/executorch that referenced this pull request Sep 13, 2024
Summary:
Pull Request resolved: pytorch#5359

- Revamp and standardize the readme docs structure for better clarity.
- Added different delegate instructions for ios.
- Added some screenshots to improve readme clarity.

Differential Revision: D62660106
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62660106

Riandy added a commit to Riandy/executorch that referenced this pull request Sep 13, 2024
Summary:
Pull Request resolved: pytorch#5359

- Revamp and standardize the readme docs structure for better clarity.
- Added different delegate instructions for ios.
- Added some screenshots to improve readme clarity.

Differential Revision: D62660106
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62660106

Riandy added a commit to Riandy/executorch that referenced this pull request Sep 14, 2024
Summary:
Pull Request resolved: pytorch#5359

- Revamp and standardize the readme docs structure for better clarity.
- Added different delegate instructions for ios.
- Added some screenshots to improve readme clarity.

Reviewed By: larryliu0820

Differential Revision: D62660106
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62660106

Riandy added a commit to Riandy/executorch that referenced this pull request Sep 14, 2024
Summary:
Pull Request resolved: pytorch#5359

- Revamp and standardize the readme docs structure for better clarity.
- Added different delegate instructions for ios.
- Added some screenshots to improve readme clarity.

Reviewed By: larryliu0820

Differential Revision: D62660106
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62660106

Riandy added a commit to Riandy/executorch that referenced this pull request Sep 14, 2024
Summary:
Pull Request resolved: pytorch#5359

- Revamp and standardize the readme docs structure for better clarity.
- Added different delegate instructions for ios.
- Added some screenshots to improve readme clarity.

Reviewed By: larryliu0820

Differential Revision: D62660106
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62660106

Riandy added a commit to Riandy/executorch that referenced this pull request Sep 14, 2024
Summary:
Pull Request resolved: pytorch#5359

- Revamp and standardize the readme docs structure for better clarity.
- Added different delegate instructions for ios.
- Added some screenshots to improve readme clarity.

Reviewed By: larryliu0820

Differential Revision: D62660106
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62660106

Riandy added a commit to Riandy/executorch that referenced this pull request Sep 14, 2024
Summary:
Pull Request resolved: pytorch#5359

- Revamp and standardize the readme docs structure for better clarity.
- Added different delegate instructions for ios.
- Added some screenshots to improve readme clarity.

Reviewed By: larryliu0820

Differential Revision: D62660106
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62660106

Riandy added a commit to Riandy/executorch that referenced this pull request Sep 14, 2024
Summary:
Pull Request resolved: pytorch#5359

- Revamp and standardize the readme docs structure for better clarity.
- Added different delegate instructions for ios.
- Added some screenshots to improve readme clarity.

Reviewed By: larryliu0820

Differential Revision: D62660106
Summary:
Pull Request resolved: pytorch#5359

- Revamp and standardize the readme docs structure for better clarity.
- Added different delegate instructions for ios.
- Added some screenshots to improve readme clarity.

Reviewed By: larryliu0820

Differential Revision: D62660106
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62660106

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 58700fa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants