Move examples/qualcomm out from under the torch namespace #5487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The code under examples/... is a proxy for user code, and users should never declare code under the `torch::` or `executorch::` namespaces. Move this code under the `example::` namespace to make it more clear that users should use their own namespaces when writing code like this. Pull Request resolved: #5400 Test Plan: - Built using the instructions at https://github.com/pytorch/executorch/blob/main/examples/qualcomm/README.md - test-llama-runner-qnn-linux CI job succeeded Reviewed By: shoumikhin Differential Revision: D62969111 Pulled By: dbort fbshipit-source-id: 9ec27528dd85f60d8c538d54ce6ddf621e63cf52 (cherry picked from commit 8ef6c79)
This was referenced Sep 19, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5487
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fe8e320 with merge base eecf74f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jackzhxng
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code under examples/... is a proxy for user code, and users should never declare code under the
torch::orexecutorch::namespaces.Move this code under the
example::namespace to make it more clear that users should use their own namespaces when writing code like this.Test Plan: