Skip to content

Update GH link in docs #5493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update GH link in docs #5493

wants to merge 1 commit into from

Conversation

kirklandsign
Copy link
Contributor

Should use the raw link instead of GH web link

Copy link

pytorch-bot bot commented Sep 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5493

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 52e11de with merge base 47f4f07 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 19, 2024
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign merged this pull request in 16673f9.

@kirklandsign
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.4 -c docs

@kirklandsign kirklandsign deleted the docs-gh-link-fix branch September 19, 2024 20:15
pytorchbot pushed a commit that referenced this pull request Sep 19, 2024
Summary:
Should use the raw link instead of GH web link

Pull Request resolved: #5493

Reviewed By: shoumikhin

Differential Revision: D63040432

Pulled By: kirklandsign

fbshipit-source-id: f6b8f1ec4fe2d7ac1c5f25cc1c727279a9d20065
(cherry picked from commit 16673f9)
@pytorchbot
Copy link
Collaborator

Cherry picking #5493

The cherry pick PR is at #5496 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

Riandy added a commit to Riandy/executorch that referenced this pull request Sep 20, 2024
Summary:
pytorch#5475 moved the images to static folder, pytorch#5493 updated some of it but missed out on the delegate specific docs.

This diff, fixes that by replacing the image URLs that are broken

Differential Revision: D63135522
jackzhxng pushed a commit that referenced this pull request Sep 20, 2024
* Update GH link in docs (#5493)

Summary:
Should use the raw link instead of GH web link

Pull Request resolved: #5493

Reviewed By: shoumikhin

Differential Revision: D63040432

Pulled By: kirklandsign

fbshipit-source-id: f6b8f1ec4fe2d7ac1c5f25cc1c727279a9d20065
(cherry picked from commit 16673f9)

* Fix link

---------

Co-authored-by: Hansong Zhang <[email protected]>
Co-authored-by: Hansong Zhang <[email protected]>
facebook-github-bot pushed a commit that referenced this pull request Sep 20, 2024
Summary:
Pull Request resolved: #5514

#5475 moved the images to static folder, #5493 updated some of it but missed out on the delegate specific docs.

This diff, fixes that by replacing the image URLs that are broken

Reviewed By: cmodi-meta, svekars, kirklandsign

Differential Revision: D63135522

fbshipit-source-id: 10071b0428c203eef38500852e64f71e13ec1315
pytorchbot pushed a commit that referenced this pull request Sep 23, 2024
Summary:
Pull Request resolved: #5514

#5475 moved the images to static folder, #5493 updated some of it but missed out on the delegate specific docs.

This diff, fixes that by replacing the image URLs that are broken

Reviewed By: cmodi-meta, svekars, kirklandsign

Differential Revision: D63135522

fbshipit-source-id: 10071b0428c203eef38500852e64f71e13ec1315
(cherry picked from commit 7de3f81)
Riandy added a commit that referenced this pull request Sep 23, 2024
Fix broken images in docs (#5514)

Summary:
Pull Request resolved: #5514

#5475 moved the images to static folder, #5493 updated some of it but missed out on the delegate specific docs.

This diff, fixes that by replacing the image URLs that are broken

Reviewed By: cmodi-meta, svekars, kirklandsign

Differential Revision: D63135522

fbshipit-source-id: 10071b0428c203eef38500852e64f71e13ec1315
(cherry picked from commit 7de3f81)

Co-authored-by: Riandy Riandy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants