[ET-VK][ez] Fix underflow error in calculate_dim_order()
#5498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context FIx an underflow error. The issue is that `ndim` is unsigned, therefore if it is `0` when it gets subtracted by one it underflows. Not sure why this wasn't caught by CI tests before. Differential Revision: [D63050011](https://our.internmc.facebook.com/intern/diff/D63050011/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5498
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4b5094d with merge base 16673f9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63050011 |
SS-JIA
added a commit
that referenced
this pull request
Sep 19, 2024
## Context FIx an underflow error. The issue is that `ndim` is unsigned, therefore if it is `0` when it gets subtracted by one it underflows. Not sure why this wasn't caught by CI tests before. Differential Revision: [D63050011](https://our.internmc.facebook.com/intern/diff/D63050011/) ghstack-source-id: 243610987 Pull Request resolved: #5498
jorgep31415
approved these changes
Sep 19, 2024
|
This pull request has been merged in 28c9a1d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
calculate_dim_order()#5498Context
FIx an underflow error. The issue is that
ndimis unsigned, therefore if it is0when it gets subtracted by one it underflows. Not sure why this wasn't caught by CI tests before.Differential Revision: D63050011