Fix broken images in docs #5514
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: pytorch#5475 moved the images to static folder, pytorch#5493 updated some of it but missed out on the delegate specific docs. This diff, fixes that by replacing the image URLs that are broken Differential Revision: D63135522
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5514
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 3360763 with merge base b5741a6 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63135522 |
cmodi-meta
approved these changes
Sep 20, 2024
kirklandsign
approved these changes
Sep 20, 2024
|
This pull request has been merged in 7de3f81. |
|
@pytorchbot cherry-pick --onto release/0.4 -c docs |
pytorchbot
pushed a commit
that referenced
this pull request
Sep 23, 2024
Summary: Pull Request resolved: #5514 #5475 moved the images to static folder, #5493 updated some of it but missed out on the delegate specific docs. This diff, fixes that by replacing the image URLs that are broken Reviewed By: cmodi-meta, svekars, kirklandsign Differential Revision: D63135522 fbshipit-source-id: 10071b0428c203eef38500852e64f71e13ec1315 (cherry picked from commit 7de3f81)
Cherry picking #5514The cherry pick PR is at #5545 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Riandy
added a commit
that referenced
this pull request
Sep 23, 2024
Fix broken images in docs (#5514) Summary: Pull Request resolved: #5514 #5475 moved the images to static folder, #5493 updated some of it but missed out on the delegate specific docs. This diff, fixes that by replacing the image URLs that are broken Reviewed By: cmodi-meta, svekars, kirklandsign Differential Revision: D63135522 fbshipit-source-id: 10071b0428c203eef38500852e64f71e13ec1315 (cherry picked from commit 7de3f81) Co-authored-by: Riandy Riandy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
#5475 moved the images to static folder, #5493 updated some of it but missed out on the delegate specific docs.
This diff, fixes that by replacing the image URLs that are broken
Differential Revision: D63135522