Skip to content

Cleaning up et_schema for OSS #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Jack-Khuu
Copy link
Contributor

Summary:
These are concepts that aren't useful in the OSS world. Associated tests were also moved

  • Moved out InferenceRun, OperatorGraphWithStats, ExportedETOperatorGraph for internal
  • Changed FXOperatorGraph to extending OperatorGraph instead of OperatorGraphWithStats
  • Tests for EDIR (to be renamed) moved to internal since they are heavily coupled with InferenceRun

Differential Revision: D49839120

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for resplendent-gnome-14e531 canceled.

Name Link
🔨 Latest commit 7484b82
🔍 Latest deploy log https://app.netlify.com/sites/resplendent-gnome-14e531/deploys/651b667436039300081250d6

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49839120

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49839120

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49839120

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49839120

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49839120

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49839120

Summary:

These are concepts that aren't useful in the OSS world. Associated tests were also moved

- Moved out InferenceRun, OperatorGraphWithStats, ExportedETOperatorGraph for internal
- Changed FXOperatorGraph to extending OperatorGraph instead of OperatorGraphWithStats
- Tests for EDIR (to be renamed) moved to internal since they are heavily coupled with InferenceRun

Reviewed By: tarun292

Differential Revision: D49839120
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49839120

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 39de0bf.

tarun292 pushed a commit that referenced this pull request Oct 5, 2023
Summary:
Pull Request resolved: #565

These are concepts that aren't useful in the OSS world. Associated tests were also moved

- Moved out InferenceRun, OperatorGraphWithStats, ExportedETOperatorGraph for internal
- Changed FXOperatorGraph to extending OperatorGraph instead of OperatorGraphWithStats
- Tests for EDIR (to be renamed) moved to internal since they are heavily coupled with InferenceRun

Reviewed By: tarun292

Differential Revision: D49839120

fbshipit-source-id: f20ba1f88f8461125b3bfd3f487c8f91d8169d7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants