fix quantized ic3/ic4/edsr examples #574
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for resplendent-gnome-14e531 canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49850155 |
|
This pull request was exported from Phabricator. Differential Revision: D49850155 |
mcr229
force-pushed
the
export-D49850155
branch
from
50a445a to
58fe1ab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49850155 |
mcr229
force-pushed
the
export-D49850155
branch
from
58fe1ab to
bb20dfe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49850155 |
mcr229
force-pushed
the
export-D49850155
branch
2 times, most recently
from
abee0ab to
acb40d6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49850155 |
Summary: The fix for quantized ic3/ic4/edsr requires runnign the pass `convert_scalars_to_attrs` after capturing_pre_autograd_graph and before preparing and converting We add using this pass in the examples to fix the quantized ic3/ic4/edsr Reviewed By: digantdesai, guangy10 Differential Revision: D49850155
mcr229
force-pushed
the
export-D49850155
branch
from
acb40d6 to
268ea49
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49850155 |
|
This pull request has been merged in 4bb03ff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The fix for quantized ic3/ic4/edsr requires runnign the pass
convert_scalars_to_attrsafter capturing_pre_autograd_graph and before preparing and convertingWe add using this pass in the examples to fix the quantized ic3/ic4/edsr
Differential Revision: D49850155