Arm backend: Add argument to list used fallback ops for run.sh #5815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This make it possible to specify what non EthosU ops to include in the build from the command line when running run.sh. As run.sh supports running models specified in files the hardcoded approch is inconvinent. Signed-off-by: Zingo Andersen <[email protected]> Change-Id: I98deb8a73d5178641a328d1200f04ec800c1b433
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5815
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit e7b3c23 with merge base 393553c ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
added
partner: arm
digantdesai
approved these changes
Oct 3, 2024
|
|
||
| help() { | ||
| echo "Usage: $(basename $0) [options]" | ||
| echo "Options:" | ||
| echo " --model_name=<MODEL> Model to run, can be a builtin, examples/models or a filename Default to all builtin models" | ||
| echo " --aot_arm_compiler_flags=<FLAGS> Only used if --model_name is used Default: ${aot_arm_compiler_flags}" | ||
| echo " --portable_kernels=<OPS> Comma separated list of portable (non delagated) kernels to include Default: ${portable_kernels}" |
There was a problem hiding this comment.
this can blow up in size as the other issue was saying, we can take in a yaml which should also allow you to specify dtype etc.
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
digantdesai
reviewed
Oct 3, 2024
|
|
||
| help() { | ||
| echo "Usage: $(basename $0) [options]" | ||
| echo "Options:" | ||
| echo " --model_name=<MODEL> Model to run, can be a builtin, examples/models or a filename Default to all builtin models" | ||
| echo " --aot_arm_compiler_flags=<FLAGS> Only used if --model_name is used Default: ${aot_arm_compiler_flags}" | ||
| echo " --portable_kernels=<OPS> Comma separated list of portable (non delagated) kernels to include Default: ${portable_kernels}" |
There was a problem hiding this comment.
so softmax is the default but it gets overwritten right? Can we make it clear in the help msg?
|
@digantdesai merged this pull request in 00d804c. |
zingo
deleted the
Arm-backend-Add-argument-to-list-used-fallback-ops-for-run.sh
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make it possible to specify what non EthosU ops to include in the build from the command line when running run.sh. As run.sh supports running models specified in files the hard coded approach is incontinent.