[ExecuTorch] Just pass SupportedTensorDtypes for each tensor to apply_ternary_elementwise_fn #5834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ternary_elementwise_fn No more function pointers! Also, we check that each Tensor's type is in the allowed set. Differential Revision: [D63794199](https://our.internmc.facebook.com/intern/diff/D63794199/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5834
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 385895a with merge base 92d1d1e ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Oct 2, 2024
|
This pull request was exported from Phabricator. Differential Revision: D63794199 |
swolchok
added a commit
that referenced
this pull request
Oct 2, 2024
…_ternary_elementwise_fn No more function pointers! Also, we check that each Tensor's type is in the allowed set. Differential Revision: [D63794199](https://our.internmc.facebook.com/intern/diff/D63794199/) ghstack-source-id: 246019385 Pull Request resolved: #5834
…or to apply_ternary_elementwise_fn" No more function pointers! Also, we check that each Tensor's type is in the allowed set. Differential Revision: [D63794199](https://our.internmc.facebook.com/intern/diff/D63794199/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D63794199 |
swolchok
added a commit
that referenced
this pull request
Oct 3, 2024
…_ternary_elementwise_fn Pull Request resolved: #5834 No more function pointers! Also, we check that each Tensor's type is in the allowed set. ghstack-source-id: 246132261 @exported-using-ghexport Differential Revision: [D63794199](https://our.internmc.facebook.com/intern/diff/D63794199/)
manuelcandales
approved these changes
Oct 3, 2024
|
This pull request has been merged in 433ead0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
No more function pointers! Also, we check that each Tensor's type is in the allowed set.
Differential Revision: D63794199