Improve iOS readme #5877
Closed
Improve iOS readme #5877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Addressing feedback from D63264488 - Rewrite the XCode setup flow for better clarity. - Added section numbering and reorder some of the flow, emphasizing which steps are recommended and which are optional (For example, user can manually build the package, but it's gonna be more involved and has to deal with lib linkage, etc) - Mentioned that package dependencies has been pre-configured and clarified instructions on how to change that if needed - Added more details on which package should link against which app target - Added more details on how to confirm which packages have been linked in case the options are greyed out Differential Revision: D63403105
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5877
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit c07ffe9 with merge base d34cc4e ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63403105 |
shoumikhin
approved these changes
Oct 8, 2024
|
This pull request has been merged in f3de2bb. |
|
@pytorchbot cherry-pick --onto release/0.4 -c docs |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 8, 2024
Summary: Pull Request resolved: #5877 Addressing feedback from D63264488 - Rewrite the XCode setup flow for better clarity. - Added section numbering and reorder some of the flow, emphasizing which steps are recommended and which are optional (For example, user can manually build the package, but it's gonna be more involved and has to deal with lib linkage, etc) - Mentioned that package dependencies has been pre-configured and clarified instructions on how to change that if needed - Added more details on which package should link against which app target - Added more details on how to confirm which packages have been linked in case the options are greyed out Reviewed By: shoumikhin Differential Revision: D63403105 fbshipit-source-id: c9867efa2d48e3e37f39b7a98b9c644390bcd3b2 (cherry picked from commit f3de2bb)
Cherry picking #5877The cherry pick PR is at #5990 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
jackzhxng
pushed a commit
that referenced
this pull request
Oct 8, 2024
Improve iOS readme (#5877) Summary: Pull Request resolved: #5877 Addressing feedback from D63264488 - Rewrite the XCode setup flow for better clarity. - Added section numbering and reorder some of the flow, emphasizing which steps are recommended and which are optional (For example, user can manually build the package, but it's gonna be more involved and has to deal with lib linkage, etc) - Mentioned that package dependencies has been pre-configured and clarified instructions on how to change that if needed - Added more details on which package should link against which app target - Added more details on how to confirm which packages have been linked in case the options are greyed out Reviewed By: shoumikhin Differential Revision: D63403105 fbshipit-source-id: c9867efa2d48e3e37f39b7a98b9c644390bcd3b2 (cherry picked from commit f3de2bb) Co-authored-by: Riandy Riandy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Addressing feedback from D63264488
Differential Revision: D63403105