Skip to content

Migrate backends/apple to the new namespace #5883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

dbort
Copy link
Contributor

@dbort dbort commented Oct 4, 2024

Summary: Move the Apple backends out of the torch:: namespace, and update to avoid using the torch:: or exec_aten:: namespaces.

Differential Revision: D63908530

Copy link

pytorch-bot bot commented Oct 4, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5883

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit ca8f76d with merge base b6e6d06 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 4, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63908530

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63908530

@dbort dbort force-pushed the export-D63908530 branch from 52411d8 to 6fb7687 Compare October 4, 2024 22:32
dbort added a commit that referenced this pull request Oct 4, 2024
Summary:
Pull Request resolved: #5883

Move the Apple backends out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces.

Differential Revision: D63908530
dbort added a commit that referenced this pull request Oct 4, 2024
Summary:
Pull Request resolved: #5883

Move the Apple backends out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces.

Differential Revision: D63908530
@dbort dbort force-pushed the export-D63908530 branch from 6fb7687 to f36acf7 Compare October 4, 2024 23:47
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63908530

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63908530

dbort added a commit that referenced this pull request Oct 4, 2024
Summary:
Pull Request resolved: #5883

Move the Apple backends out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces.

Differential Revision: D63908530
@dbort dbort force-pushed the export-D63908530 branch from f36acf7 to c4a215d Compare October 4, 2024 23:56
facebook-github-bot pushed a commit that referenced this pull request Oct 7, 2024
Summary:

Move the MPS backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces.

Differential Revision: D63908530
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63908530

@cccclai cccclai requested a review from DenisVieriu97 October 7, 2024 19:04
facebook-github-bot pushed a commit that referenced this pull request Oct 8, 2024
Summary:

Move the MPS backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces.

Differential Revision: D63908530
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63908530

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if CI passes.

Copy link
Collaborator

@DenisVieriu97 DenisVieriu97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Summary:

Move the MPS backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces.

Reviewed By: cccclai

Differential Revision: D63908530
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63908530

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in c4a2eeb.

@dbort
Copy link
Contributor Author

dbort commented Oct 9, 2024

@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature

@dbort dbort deleted the export-D63908530 branch October 9, 2024 18:07
pytorchbot pushed a commit that referenced this pull request Oct 9, 2024
Summary:
Pull Request resolved: #5883

Move the MPS backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces.

Reviewed By: cccclai

Differential Revision: D63908530

fbshipit-source-id: 80ae5001ae950eaa16197e11923d7a4ccf76f7c0
(cherry picked from commit c4a2eeb)
@pytorchbot
Copy link
Collaborator

Cherry picking #5883

The cherry pick PR is at #6058 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants