-
Notifications
You must be signed in to change notification settings - Fork 608
Migrate backends/apple to the new namespace #5883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5883
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit ca8f76d with merge base b6e6d06 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D63908530 |
This pull request was exported from Phabricator. Differential Revision: D63908530 |
52411d8
to
6fb7687
Compare
Summary: Pull Request resolved: #5883 Move the Apple backends out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces. Differential Revision: D63908530
Summary: Pull Request resolved: #5883 Move the Apple backends out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces. Differential Revision: D63908530
6fb7687
to
f36acf7
Compare
This pull request was exported from Phabricator. Differential Revision: D63908530 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D63908530 |
Summary: Pull Request resolved: #5883 Move the Apple backends out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces. Differential Revision: D63908530
f36acf7
to
c4a215d
Compare
Summary: Move the MPS backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces. Differential Revision: D63908530
c4a215d
to
1822658
Compare
This pull request was exported from Phabricator. Differential Revision: D63908530 |
1822658
to
f01dfb8
Compare
Summary: Move the MPS backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces. Differential Revision: D63908530
This pull request was exported from Phabricator. Differential Revision: D63908530 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good if CI passes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Summary: Move the MPS backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces. Reviewed By: cccclai Differential Revision: D63908530
f01dfb8
to
ca8f76d
Compare
This pull request was exported from Phabricator. Differential Revision: D63908530 |
This pull request has been merged in c4a2eeb. |
@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature |
Summary: Pull Request resolved: #5883 Move the MPS backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces. Reviewed By: cccclai Differential Revision: D63908530 fbshipit-source-id: 80ae5001ae950eaa16197e11923d7a4ccf76f7c0 (cherry picked from commit c4a2eeb)
Cherry picking #5883The cherry pick PR is at #6058 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Summary: Move the Apple backends out of the
torch::
namespace, and update to avoid using thetorch::
orexec_aten::
namespaces.Differential Revision: D63908530