Skip to content

Forward fix test_create_submodule_list_return to be backwards compatible #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Forward fix test_create_submodule_list_return to be backwards compatible #591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions exir/tests/test_delegate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,9 +288,13 @@ def forward(self, x, y):

node_list = []
for node in gm.graph.nodes:
if (
node.op == "call_function"
and node.target == exir_ops.edge.aten.split_with_sizes_copy.default
# TODO(ssjia): split.Tensor now gets decomposed to split_with_sizes. Due to how executorch uses a pinned Pytorch
# nightly, the CI may not catch the changes to Pytorch's core decomposition table. As a temporary workaround,
# make the test backwards compatible with the old decomposition table. Remove the or statement once Pytorch nightly
# has been updated.
if node.op == "call_function" and (
node.target == exir_ops.edge.aten.split_with_sizes_copy.default
or node.target == exir_ops.edge.aten.split_copy.Tensor
):
node_list.append(node)

Expand Down