Move qualcomm.passes to qualcomm._passes #5920

tarun292 · 2024-10-06T07:02:30Z

Differential Revision: D63926845

pytorch-bot · 2024-10-06T07:02:33Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5920

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2244233 with merge base da1d2ca ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-10-06T07:03:06Z

This pull request was exported from Phabricator. Differential Revision: D63926845

facebook-github-bot · 2024-10-07T15:16:46Z

This pull request was exported from Phabricator. Differential Revision: D63926845

Summary: Changing qualcomm.passes to qualcomm._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5920 Differential Revision: D63926845

facebook-github-bot · 2024-10-07T15:23:09Z

This pull request was exported from Phabricator. Differential Revision: D63926845

Summary: Changing qualcomm.passes to qualcomm._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5920 Differential Revision: D63926845

facebook-github-bot · 2024-10-07T23:18:27Z

This pull request was exported from Phabricator. Differential Revision: D63926845

Summary: Changing qualcomm.passes to qualcomm._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5920 Reviewed By: helunwencser Differential Revision: D63926845

chiwwang · 2024-10-08T02:53:13Z

@haowhsu-quic @shewu-quic @chunit-quic @winskuo-quic

shewu-quic

If possible, could you help to change this line in README.md

Summary: Changing qualcomm.passes to qualcomm._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5920 Reviewed By: helunwencser Differential Revision: D63926845

facebook-github-bot · 2024-10-08T16:32:33Z

This pull request was exported from Phabricator. Differential Revision: D63926845

facebook-github-bot · 2024-10-08T16:42:42Z

This pull request was exported from Phabricator. Differential Revision: D63926845

Summary: Changing qualcomm.passes to qualcomm._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5920 Reviewed By: helunwencser Differential Revision: D63926845

facebook-github-bot · 2024-10-08T20:18:29Z

This pull request was exported from Phabricator. Differential Revision: D63926845

Summary: Changing qualcomm.passes to qualcomm._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5920 Reviewed By: helunwencser Differential Revision: D63926845

facebook-github-bot · 2024-10-08T20:25:28Z

This pull request was exported from Phabricator. Differential Revision: D63926845

facebook-github-bot · 2024-10-08T23:04:51Z

This pull request was exported from Phabricator. Differential Revision: D63926845

Summary: Changing qualcomm.passes to qualcomm._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5920 Reviewed By: helunwencser Differential Revision: D63926845

facebook-github-bot · 2024-10-08T23:11:40Z

This pull request was exported from Phabricator. Differential Revision: D63926845

facebook-github-bot · 2024-10-09T08:45:26Z

This pull request was exported from Phabricator. Differential Revision: D63926845

Summary: Changing qualcomm.passes to qualcomm._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5920 Reviewed By: helunwencser Differential Revision: D63926845

facebook-github-bot · 2024-10-09T08:52:14Z

This pull request was exported from Phabricator. Differential Revision: D63926845

facebook-github-bot · 2024-10-09T20:54:54Z

This pull request has been merged in 866b40c.

tarun292 · 2024-10-10T06:22:21Z

@pytorchbot cherry-pick --onto release/0.4 -c critical

pytorchbot · 2024-10-10T06:23:55Z

Cherry picking #5920

Command git -C /home/runner/work/executorch/executorch cherry-pick -x -X theirs 866b40c72e5e8814e55dbb253e356366db282267 returned non-zero exit code 1

Auto-merging backends/qualcomm/TARGETS
CONFLICT (rename/delete): backends/qualcomm/passes/TARGETS renamed to backends/qualcomm/_passes/TARGETS in 866b40c72 (Move qualcomm.passes to qualcomm._passes (#5920)), but deleted in HEAD.
Auto-merging backends/qualcomm/quantizer/quantizer.py
Auto-merging backends/qualcomm/utils/constants.py
Auto-merging backends/qualcomm/utils/utils.py
Auto-merging examples/qualcomm/oss_scripts/llama2/llama.py
error: could not apply 866b40c72... Move qualcomm.passes to qualcomm._passes (#5920)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

Summary: A new pass is added after pytorch#5920 Differential Revision: D64190781

Summary: Changing qualcomm.passes to qualcomm._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: pytorch#5920 Reviewed By: helunwencser Differential Revision: D63926845 fbshipit-source-id: f1e3187f3012f83b388d9635ca5a244fa36950d6 (cherry picked from commit 866b40c)

Summary: Pull Request resolved: pytorch#6110 A new pass is added after pytorch#5920 Differential Revision: D64190781

Summary: Changing qualcomm.passes to qualcomm._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5920 Reviewed By: helunwencser Differential Revision: D63926845 fbshipit-source-id: f1e3187f3012f83b388d9635ca5a244fa36950d6 (cherry picked from commit 866b40c)

Summary: Pull Request resolved: pytorch#6110 A new pass is added after pytorch#5920 Reviewed By: tarun292 Differential Revision: D64190781

Summary: Pull Request resolved: #6110 A new pass is added after #5920 bypass-github-export-checks Reviewed By: tarun292 Differential Revision: D64190781 fbshipit-source-id: a2fe9dedf502f7ff743a9f37ea8bee5f190227ea

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2024

facebook-github-bot added the fb-exported label Oct 6, 2024

tarun292 force-pushed the export-D63926845 branch from 9762c3b to a096bf3 Compare October 7, 2024 15:16

tarun292 force-pushed the export-D63926845 branch from a096bf3 to 8ec9d00 Compare October 7, 2024 15:23

helunwencser approved these changes Oct 7, 2024

View reviewed changes

cccclai requested a review from chiwwang October 7, 2024 18:36

cccclai added the ciflow/trunk label Oct 7, 2024

tarun292 force-pushed the export-D63926845 branch from 8ec9d00 to 8b3c171 Compare October 7, 2024 23:18

shewu-quic approved these changes Oct 8, 2024

View reviewed changes

tarun292 force-pushed the export-D63926845 branch from 8b3c171 to ec2074b Compare October 8, 2024 16:32

tarun292 force-pushed the export-D63926845 branch from ec2074b to afef17f Compare October 8, 2024 16:42

tarun292 force-pushed the export-D63926845 branch from afef17f to 000983b Compare October 8, 2024 20:18

tarun292 force-pushed the export-D63926845 branch from 000983b to fedc579 Compare October 8, 2024 20:25

tarun292 force-pushed the export-D63926845 branch from 828b8f0 to 8c26e78 Compare October 8, 2024 22:39

tarun292 force-pushed the export-D63926845 branch from 8c26e78 to fe8a8fd Compare October 8, 2024 23:04

tarun292 force-pushed the export-D63926845 branch from fe8a8fd to aec2a28 Compare October 8, 2024 23:11

tarun292 force-pushed the export-D63926845 branch from aec2a28 to 17097a5 Compare October 9, 2024 08:45

Move qualcomm.passes to qualcomm._passes (#5920)

2244233

Summary: Changing qualcomm.passes to qualcomm._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5920 Reviewed By: helunwencser Differential Revision: D63926845

tarun292 force-pushed the export-D63926845 branch from 17097a5 to 2244233 Compare October 9, 2024 08:52

facebook-github-bot closed this in 866b40c Oct 9, 2024

facebook-github-bot added the Merged label Oct 9, 2024

cccclai mentioned this pull request Oct 10, 2024

Fix qualcomm passes #6110

Closed

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Oct 10, 2024

Fix qualcomm passes

7788a81

Summary: A new pass is added after pytorch#5920 Differential Revision: D64190781

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Oct 10, 2024

Fix qualcomm passes (pytorch#6110)

c248399

Summary: Pull Request resolved: pytorch#6110 A new pass is added after pytorch#5920 Differential Revision: D64190781

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Oct 10, 2024

Fix qualcomm passes (pytorch#6110)

a38e408

Summary: Pull Request resolved: pytorch#6110 A new pass is added after pytorch#5920 Differential Revision: D64190781

This was referenced Oct 10, 2024

Move qualcomm.passes to qualcomm._passes #6126

Closed

[v0.4.0] Release Tracker #5366

Closed

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Oct 11, 2024

Fix qualcomm passes (pytorch#6110)

ffcb851

Summary: Pull Request resolved: pytorch#6110 A new pass is added after pytorch#5920 Reviewed By: tarun292 Differential Revision: D64190781

Move qualcomm.passes to qualcomm._passes #5920

Move qualcomm.passes to qualcomm._passes #5920

Uh oh!

Conversation

tarun292 commented Oct 6, 2024

Uh oh!

pytorch-bot bot commented Oct 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5920

✅ No Failures

Uh oh!

facebook-github-bot commented Oct 6, 2024

Uh oh!

facebook-github-bot commented Oct 7, 2024

Uh oh!

facebook-github-bot commented Oct 7, 2024

Uh oh!

facebook-github-bot commented Oct 7, 2024

Uh oh!

chiwwang commented Oct 8, 2024

Uh oh!

shewu-quic left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

tarun292 commented Oct 10, 2024

Uh oh!

pytorchbot commented Oct 10, 2024

Cherry picking #5920

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 6, 2024 •

edited

Loading