Update Llama README.md for Stories110M tokenizer #5960
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5960
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fbee9be with merge base f005dd5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tarun292
approved these changes
Oct 8, 2024
tarun292
approved these changes
Oct 8, 2024
|
@dvorjackz merged this pull request in 12cb9ca. |
|
@pytorchbot cherry-pick --onto release/0.4 -c docs |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 8, 2024
Summary: The tokenizer from `wget "https://raw.githubusercontent.com/karpathy/llama2.c/master/tokenizer.model"` is TikToken, so we do not need to generate a `tokenizer.bin` and instead can just use the `tokenizer.model` as is. Pull Request resolved: #5960 Reviewed By: tarun292 Differential Revision: D64014160 Pulled By: dvorjackz fbshipit-source-id: 16474a73ed77192f58a5bb9e07426ba58216351e (cherry picked from commit 12cb9ca)
Cherry picking #5960The cherry pick PR is at #5975 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
jackzhxng
added a commit
that referenced
this pull request
Oct 8, 2024
Update Llama README.md for Stories110M tokenizer (#5960) Summary: The tokenizer from `wget "https://raw.githubusercontent.com/karpathy/llama2.c/master/tokenizer.model"` is TikToken, so we do not need to generate a `tokenizer.bin` and instead can just use the `tokenizer.model` as is. Pull Request resolved: #5960 Reviewed By: tarun292 Differential Revision: D64014160 Pulled By: dvorjackz fbshipit-source-id: 16474a73ed77192f58a5bb9e07426ba58216351e (cherry picked from commit 12cb9ca) Co-authored-by: Jack Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The tokenizer from
wget "https://raw.githubusercontent.com/karpathy/llama2.c/master/tokenizer.model"is TikToken, so we do not need to generate atokenizer.binand instead can just use thetokenizer.modelas is.