Skip to content

[ET][Portable][Build Size] Reduce build size of op_cumsum #6021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

manuelcandales
Copy link
Contributor

@manuelcandales manuelcandales commented Oct 8, 2024

Copy link

pytorch-bot bot commented Oct 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6021

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ccd28d7 with merge base cb12061 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63997235

manuelcandales added a commit that referenced this pull request Oct 8, 2024
98 K -> 9 K

Differential Revision: [D63997235](https://our.internmc.facebook.com/intern/diff/D63997235/)

ghstack-source-id: 246919725
Pull Request resolved: #6021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63997235

manuelcandales added a commit that referenced this pull request Oct 8, 2024
Pull Request resolved: #6021

98 K -> 9 K
ghstack-source-id: 246939834
@exported-using-ghexport

Differential Revision: [D63997235](https://our.internmc.facebook.com/intern/diff/D63997235/)
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it can make code a bit slower, wouldn't it?

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63997235

manuelcandales added a commit that referenced this pull request Oct 8, 2024
Pull Request resolved: #6021

98 K -> 9 K
ghstack-source-id: 246944190
@exported-using-ghexport

Differential Revision: [D63997235](https://our.internmc.facebook.com/intern/diff/D63997235/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63997235

manuelcandales added a commit that referenced this pull request Oct 9, 2024
Pull Request resolved: #6021

98 K -> 9 K
ghstack-source-id: 246981816
@exported-using-ghexport

Differential Revision: [D63997235](https://our.internmc.facebook.com/intern/diff/D63997235/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63997235

manuelcandales added a commit that referenced this pull request Oct 9, 2024
Pull Request resolved: #6021

98 K -> 9 K
ghstack-source-id: 246985127
@exported-using-ghexport

Differential Revision: [D63997235](https://our.internmc.facebook.com/intern/diff/D63997235/)
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1a6ba2e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants