Revert D63918659 #6027
Closed
Revert D63918659 #6027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff reverts D63918659 Depends on D64075419 This is breaking the OSS `unittest / linux / linux-job` build: https://github.com/pytorch/executorch/actions/runs/11242482373/job/31256276319 ``` /pytorch/executorch/backends/vulkan/runtime/graph/ops/impl/Staging.cpp:83:26: error: no member named 'starts_with' in 'std::basic_string<char>' if (shader.kernel_name.starts_with("bitw8_image_to_nchw_nobitw8buffer")) { ~~~~~~~~~~~~~~~~~~ ^ 1 error generated. gmake[2]: *** [backends/vulkan/CMakeFiles/vulkan_backend.dir/build.make:636: backends/vulkan/CMakeFiles/vulkan_backend.dir/runtime/graph/ops/impl/Staging.cpp.o] Error 1 gmake[2]: *** Waiting for unfinished jobs.... ``` Reviewed By: dbort Differential Revision: D64075435
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6027
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit 5366683 with merge base ed9f50f ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64075435 |
kirklandsign
approved these changes
Oct 8, 2024
SS-JIA
approved these changes
Oct 8, 2024
|
This pull request has been merged in b6e6d06. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff reverts D63918659
Depends on D64075419
This is breaking the OSS
unittest / linux / linux-jobbuild:https://github.com/pytorch/executorch/actions/runs/11242482373/job/31256276319
Reviewed By: dbort
Differential Revision: D64075435