-
Notifications
You must be signed in to change notification settings - Fork 607
s/exec_aten::/executorch::aten::/ for extension/**/*.h #6032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6032
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit be4b861 with merge base 1a6ba2e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D64079593 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust that you did it with some sort of regex, but wouldn't it be a BC-break change?
Summary: Migrate all extension headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later. Reviewed By: lucylq Differential Revision: D64079593
59fb7bb
to
d80e75d
Compare
This pull request was exported from Phabricator. Differential Revision: D64079593 |
Summary: Migrate all extension headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later. Reviewed By: lucylq Differential Revision: D64079593
d80e75d
to
32afe35
Compare
This pull request was exported from Phabricator. Differential Revision: D64079593 |
Summary: Migrate all extension headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later. Reviewed By: lucylq Differential Revision: D64079593
f7ae243
to
be4b861
Compare
Summary: Migrate all extension headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later. Reviewed By: lucylq Differential Revision: D64079593
This pull request was exported from Phabricator. Differential Revision: D64079593 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D64079593 |
This pull request has been merged in 69c2c76. |
@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature |
Summary: Pull Request resolved: #6032 Migrate all extension headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later. Reviewed By: lucylq Differential Revision: D64079593 fbshipit-source-id: 62164cd6ec3238e21e896813f185d0c1446ef527 (cherry picked from commit 69c2c76)
Cherry picking #6032The cherry pick PR is at #6106 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Summary: Pull Request resolved: #6032 Migrate all extension headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later. Reviewed By: lucylq Differential Revision: D64079593 fbshipit-source-id: 62164cd6ec3238e21e896813f185d0c1446ef527 (cherry picked from commit 69c2c76)
s/exec_aten::/executorch::aten::/ for extension/**/*.h (#6032) Summary: Pull Request resolved: #6032 Migrate all extension headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later. Reviewed By: lucylq Differential Revision: D64079593 fbshipit-source-id: 62164cd6ec3238e21e896813f185d0c1446ef527 (cherry picked from commit 69c2c76) Co-authored-by: Dave Bort <[email protected]>
Summary: Migrate all extension headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later.
Differential Revision: D64079593