Skip to content

s/exec_aten::/executorch::aten::/ for extension/**/*.h #6032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dbort
Copy link
Contributor

@dbort dbort commented Oct 8, 2024

Summary: Migrate all extension headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later.

Differential Revision: D64079593

Copy link

pytorch-bot bot commented Oct 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6032

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit be4b861 with merge base 1a6ba2e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64079593

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust that you did it with some sort of regex, but wouldn't it be a BC-break change?

dbort added a commit to dbort/executorch that referenced this pull request Oct 9, 2024
Summary:

Migrate all extension headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later.

Reviewed By: lucylq

Differential Revision: D64079593
@dbort dbort force-pushed the export-D64079593 branch from 59fb7bb to d80e75d Compare October 9, 2024 04:40
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64079593

dbort added a commit to dbort/executorch that referenced this pull request Oct 9, 2024
Summary:

Migrate all extension headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later.

Reviewed By: lucylq

Differential Revision: D64079593
@dbort dbort force-pushed the export-D64079593 branch from d80e75d to 32afe35 Compare October 9, 2024 18:09
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64079593

Summary:

Migrate all extension headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later.

Reviewed By: lucylq

Differential Revision: D64079593
@dbort dbort force-pushed the export-D64079593 branch 2 times, most recently from f7ae243 to be4b861 Compare October 10, 2024 00:49
dbort added a commit to dbort/executorch that referenced this pull request Oct 10, 2024
Summary:

Migrate all extension headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later.

Reviewed By: lucylq

Differential Revision: D64079593
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64079593

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64079593

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 69c2c76.

@dbort dbort deleted the export-D64079593 branch October 10, 2024 17:49
@dbort
Copy link
Contributor Author

dbort commented Oct 10, 2024

@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature

pytorchbot pushed a commit that referenced this pull request Oct 10, 2024
Summary:
Pull Request resolved: #6032

Migrate all extension headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later.

Reviewed By: lucylq

Differential Revision: D64079593

fbshipit-source-id: 62164cd6ec3238e21e896813f185d0c1446ef527
(cherry picked from commit 69c2c76)
@pytorchbot
Copy link
Collaborator

Cherry picking #6032

The cherry pick PR is at #6106 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

dbort added a commit that referenced this pull request Oct 11, 2024
Summary:
Pull Request resolved: #6032

Migrate all extension headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later.

Reviewed By: lucylq

Differential Revision: D64079593

fbshipit-source-id: 62164cd6ec3238e21e896813f185d0c1446ef527
(cherry picked from commit 69c2c76)
dbort added a commit that referenced this pull request Oct 11, 2024
s/exec_aten::/executorch::aten::/ for extension/**/*.h (#6032)

Summary:
Pull Request resolved: #6032

Migrate all extension headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later.

Reviewed By: lucylq

Differential Revision: D64079593

fbshipit-source-id: 62164cd6ec3238e21e896813f185d0c1446ef527
(cherry picked from commit 69c2c76)

Co-authored-by: Dave Bort <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants