Skip to content

Cover MPS models in the CI #6036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Cover MPS models in the CI #6036

wants to merge 1 commit into from

Conversation

guangy10
Copy link
Contributor

@guangy10 guangy10 commented Oct 9, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6036

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0d70b3c with merge base 0ce221e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2024
@guangy10 guangy10 force-pushed the mps_models_benchinfra branch 2 times, most recently from a5a7287 to 5a6e187 Compare October 9, 2024 18:22
@guangy10 guangy10 marked this pull request as ready for review October 9, 2024 18:23
@guangy10
Copy link
Contributor Author

guangy10 commented Oct 9, 2024

Will cover these mps models in the benchmarking infra

@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 force-pushed the mps_models_benchinfra branch from 5a6e187 to 6f19979 Compare October 9, 2024 22:01
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 force-pushed the mps_models_benchinfra branch from 6f19979 to 0d70b3c Compare October 9, 2024 22:08
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@guangy10 merged this pull request in 554eebe.

@guangy10
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature

pytorchbot pushed a commit that referenced this pull request Oct 10, 2024
@pytorchbot
Cover MPS models in the CI (#6036)
07bc3e4 
Summary: Pull Request resolved: #6036

Reviewed By: kirklandsign

Differential Revision: D64126006

Pulled By: guangy10

fbshipit-source-id: c5aa5a69b9371391f8c300d8f0ee3409ffc76a1f
(cherry picked from commit 554eebe)
@pytorchbot
Copy link
Collaborator

Cherry picking #6036

The cherry pick PR is at #6081 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Oct 10, 2024
Closed
@guangy10
Copy link
Contributor Author

No need to cherry-pick

@guangy10 guangy10 deleted the mps_models_benchinfra branch October 10, 2024 18:10
@guangy10
Copy link
Contributor Author

guangy10 commented Oct 10, 2024 •
edited
Loading

@shoumikhin It looks like the model name is hard-coded somewhere in the app. I will fix the broken build-ios-demo job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoumikhin shoumikhin shoumikhin approved these changes

@DenisVieriu97 DenisVieriu97 Awaiting requested review from DenisVieriu97

@huydhn huydhn Awaiting requested review from huydhn

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guangy10 @facebook-github-bot @pytorchbot @shoumikhin