Update executorch-arm-delegate-tutorial.md #6040
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing code snippets, given they will get quickly outdated. Instead referring directly to the functions in the `setup.sh` and `run.sh`. We can figure out a way to do some better automation but since what we had was outdated I feel this is the right thing to do in the short term.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6040
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 246ae13 with merge base 01fcdf4 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
robell
approved these changes
Oct 9, 2024
|
LGTM. Is this being cherry-picked to the release branch? Once this is in, we should make some followup changes around the CS320 enablement on trunk, but as that's not all on 0.4 this seems like a good step. |
|
@robell - 100%. |
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@digantdesai merged this pull request in 243fffc. |
|
@pytorchbot cherry-pick --onto release/0.4 -c docs |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 9, 2024
Summary: Removing code snippets, given they will get quickly outdated. Instead referring directly to the functions in the `setup.sh` and `run.sh`. We can figure out a way to do some better automation but since what we had was outdated I feel this is the right thing to do in the short term. Pull Request resolved: #6040 Reviewed By: mergennachin Differential Revision: D64113182 Pulled By: digantdesai fbshipit-source-id: 1c195afc7a26c062f6db8fc44d254c80232a761b (cherry picked from commit 243fffc)
Cherry picking #6040The cherry pick PR is at #6065 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
jackzhxng
pushed a commit
that referenced
this pull request
Oct 9, 2024
Update executorch-arm-delegate-tutorial.md (#6040) Summary: Removing code snippets, given they will get quickly outdated. Instead referring directly to the functions in the `setup.sh` and `run.sh`. We can figure out a way to do some better automation but since what we had was outdated I feel this is the right thing to do in the short term. Pull Request resolved: #6040 Reviewed By: mergennachin Differential Revision: D64113182 Pulled By: digantdesai fbshipit-source-id: 1c195afc7a26c062f6db8fc44d254c80232a761b (cherry picked from commit 243fffc) Co-authored-by: Digant Desai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing code snippets, given they will get quickly outdated. Instead referring directly to the functions in the
setup.shandrun.sh.We can figure out a way to do some better automation but since what we had was outdated I feel this is the right thing to do in the short term.