[ET-VK] Update RemoveLocalScalarDenseOpsTransform to tag scalar tensors as well
#6069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sors as well ## Context See the new docstrings added to `remove_local_scalar_dense_ops` for more details on what the pass is trying to achieve. The goal is to mark tensors that are consumed as scalars via `tensor[0].item()` as "scalar tensors" that will be represented as a `SymInt` object in the vulkan delegate instead of a regular `Tensor` object. This diff also adds an `__init__.py` file to the `_passes` folder to make it easier to include Vulkan passes from one place. Differential Revision: [D64139867](https://our.internmc.facebook.com/intern/diff/D64139867/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6069
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b7bca17 with merge base 866b40c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64139867 |
jorgep31415
approved these changes
Oct 9, 2024
|
This pull request has been merged in 1a0c2c7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
RemoveLocalScalarDenseOpsTransformto tag scalar tensors as well #6069Context
See the new docstrings added to
remove_local_scalar_dense_opsfor more details on what the pass is trying to achieve.The goal is to mark tensors that are consumed as scalars via
tensor[0].item()as "scalar tensors" that will be represented as aSymIntobject in the vulkan delegate instead of a regularTensorobject.This diff also adds an
__init__.pyfile to the_passesfolder to make it easier to include Vulkan passes from one place.Differential Revision: D64139867