Rename capture_pre_autograd_graph private method #6214
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6214
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 553eb7e with merge base e342a92 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D64370367 |
facebook-github-bot
added
CLA Signed
helunwencser
approved these changes
Oct 15, 2024
Summary: These are mainly no-op changes. The underlying function is already changed. git grep `capture_pre_autograd_graph` finds these helper functions but in fact we already done migrating. So let's change the name of the method This is not going to be cherry-picked, but fixed in main. Reviewed By: helunwencser Differential Revision: D64370367
mergennachin
force-pushed
the
export-D64370367
branch
from
f379df1 to
553eb7e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64370367 |
|
This pull request has been merged in 254bdf9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These are mainly no-op changes. The underlying function is already changed.
git grep
capture_pre_autograd_graphfinds these helper functions but in fact we already done migrating.So let's change the name of the method
This is not going to be cherry-picked, but fixed in main.
Differential Revision: D64370367