check to_copy args in vulkan_partitioner #6215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: in exir dialect, to_copy doesn't have dtype arg and it is inferred from the dtype of the output tensor. The args will be of length 1 with the sole arg being the input tensor. Thus the previous check always returns False as args is never > 1. Differential Revision: D64267104
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6215
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5670a80 with merge base bff26f3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/periodic
module: vulkan
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64267104 |
SS-JIA
approved these changes
Oct 15, 2024
|
This pull request has been merged in 708c6b6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: in exir dialect, to_copy doesn't have dtype arg and it is inferred from the dtype of the output tensor. The args will be of length 1 with the sole arg being the input tensor. Thus the previous check always returns False as args is never > 1.
Differential Revision: D64267104