Skip to content

fix eager run for cuda #6365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

helunwencser
Copy link
Contributor

@helunwencser helunwencser commented Oct 18, 2024

Stack from ghstack (oldest at bottom):

This PR allows us to run the eager runner on GPU machines.

Test Plan:

python -m examples.models.llama.runner.eager \
          -c /home/lunwenh/models/1B_Instruct/consolidated.00.pth \
          -p /home/lunwenh/models/1B_Instruct/params.json \
          -t /home/lunwenh/models/1B_Instruct/tokenizer.model \
          -kv \
          -d bf16 \
          --max_seq_length 128 \
          --prompt "<|begin_of_text|><|start_header_id|>system<|end_header_id|>

You are a good assistant<|eot_id|><|start_header_id|>user<|end_header_id|>

What is the capital of France?<|eot_id|><|start_header_id|>assistant<|end_header_id|>"
Response: 
The capital of France is Paris.
 Tokens:
 [791, 6864, 315, 9822, 374, 12366, 13]

Differential Revision: D64713144

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Oct 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6365

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 13a3ade with merge base 1e9ebdf (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

helunwencser added a commit that referenced this pull request Oct 18, 2024
ghstack-source-id: 35f8e34
Pull Request resolved: #6365
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 18, 2024
helunwencser added a commit that referenced this pull request Oct 21, 2024
ghstack-source-id: d17ff4b
Pull Request resolved: #6365
helunwencser added a commit that referenced this pull request Oct 21, 2024
ghstack-source-id: 8278f05
Pull Request resolved: #6365
@helunwencser
Copy link
Contributor Author

@helunwencser has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mergennachin mergennachin self-requested a review October 21, 2024 21:09
@helunwencser
Copy link
Contributor Author

@helunwencser has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@helunwencser
Copy link
Contributor Author

@helunwencser has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit 30be60c into gh/helunwencser/59/base Oct 22, 2024
45 of 46 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/helunwencser/59/head branch October 22, 2024 01:50
kirklandsign added a commit that referenced this pull request Oct 22, 2024
ghstack-source-id: 8278f05
Pull Request resolved: #6365

Co-authored-by: Lunwen He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants