Skip to content

executorch/examples/portable/custom_ops/custom_ops_2_out.cpp: fix llvm-17-exposed format mismatches #6368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

meyering
Copy link
Contributor

Summary:
This avoids the following errors:

executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:23:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat]
executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:27:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat]

Differential Revision: D64656845

Copy link

pytorch-bot bot commented Oct 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6368

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b787f2f with merge base c7a3c3f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 19, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64656845

meyering pushed a commit to meyering/executorch that referenced this pull request Oct 20, 2024
…m-17-exposed format mismatches (pytorch#6368)

Summary:

This avoids the following errors:

  executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:23:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat]
  executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:27:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat]

Differential Revision: D64656845
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64656845

meyering pushed a commit to meyering/executorch that referenced this pull request Oct 20, 2024
…m-17-exposed format mismatches (pytorch#6368)

Summary:

This avoids the following errors:

  executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:23:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat]
  executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:27:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat]

Also, change the format to %d and the cast to match -- perhaps a little more future-safe.

Differential Revision: D64656845
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64656845

meyering pushed a commit to meyering/executorch that referenced this pull request Oct 21, 2024
…m-17-exposed format mismatches (pytorch#6368)

Summary:

This avoids the following errors:

  executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:23:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat]
  executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:27:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat]

Also, change the format to %d and the cast to match -- perhaps a little more future-safe.

Differential Revision: D64656845
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64656845

…m-17-exposed format mismatches (pytorch#6368)

Summary:

This avoids the following errors:

  executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:23:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat]
  executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:27:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat]

Also, change the format to %d and the cast to match -- perhaps a little more future-safe.

Differential Revision: D64656845
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64656845

@facebook-github-bot facebook-github-bot merged commit 8c96805 into pytorch:main Oct 22, 2024
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants