Skip to content

Add EXECUTORCH_ENABLE_LOGGING and EXECUTORCH_ENABLE_PROGRAM_VERIFICATION #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add EXECUTORCH_ENABLE_LOGGING and EXECUTORCH_ENABLE_PROGRAM_VERIFICATION #638

wants to merge 1 commit into from

Conversation

dbort
Copy link
Contributor

@dbort dbort commented Oct 5, 2023

Summary:

These flags should be off by default in Release mode, but some users may want to enable them.

This sets a convention for future options like this, which should also use ${_default_release_disabled_targets}.
ghstack-source-id: 202924824
exported-using-ghexport

Reviewed By: digantdesai

Differential Revision: D49925195

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for resplendent-gnome-14e531 canceled.

Name Link
🔨 Latest commit c8c10a7
🔍 Latest deploy log https://app.netlify.com/sites/resplendent-gnome-14e531/deploys/651f0d5b908453000703129e

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 5, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49925195

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49925195

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49925195

…ION (#638)

Summary:

These flags should be off by default in Release mode, but some users may want to enable them.

This sets a convention for future options like this, which should also use `${_default_release_disabled_targets}`.

Reviewed By: digantdesai

Differential Revision: D49925195
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49925195

@dbort dbort changed the title Add EXECUTORCH_ENABLE_LOGGING and EXECUTORCH_ENABLE_PROGRAM_VERIFICATION (#617) Add EXECUTORCH_ENABLE_LOGGING and EXECUTORCH_ENABLE_PROGRAM_VERIFICATION Oct 5, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 43eb74d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants