Skip to content

Qualcomm AI Engine Direct - Fix Per Layer Dump #6384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

Qualcomm AI Engine Direct - Fix Per Layer Dump #6384

merged 1 commit into from
Oct 22, 2024

Conversation

winskuo-quic
Copy link
Collaborator

Summary

  • Only dump native tensors for intermediate tensor dump

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6384

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 73a646e with merge base ca47839 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2024
@winskuo-quic
Copy link
Collaborator Author

Hi @cccclai,
This PR is to fix RMS Norm error when doing intermediate tensor dump. It seems like bias tensor is set as output tensor, which causes QNN finalize fail. I added a new condition to ensure we only dump native tensors during intermediate tensor dump.

cccclai
cccclai approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for the fix!

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai
Copy link
Contributor

cccclai commented Oct 21, 2024

Hi, looks like this PR base commit is a bit old, mind rebasing it?

@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/per_tensor_dump_fix branch from a0002ce to 73a646e Compare October 22, 2024 00:59
@winskuo-quic
Copy link
Collaborator Author

Hi, looks like this PR base commit is a bit old, mind rebasing it?

Hi,
Thanks for reviewing the PR.
I have just rebased.

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai cccclai merged commit 5a34bc1 into pytorch:main Oct 22, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai cccclai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winskuo-quic @facebook-github-bot @cccclai