Skip to content

Qualcomm AI Engine Direct - Update the evaluator API call for Llama #6386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

winskuo-quic
Copy link
Collaborator

Summary

Due to the changes introduced in add option to run mmlu with 5 shots by helunwencser · Pull Request #6146 · pytorch/executorch (github.com), the evaluate_model function has been removed. Please use simple_evaluate for evaluation purposes.

PR Owner: YuYang Zhuang

Copy link

pytorch-bot bot commented Oct 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6386

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 7f26d31 with merge base ad0e5e8 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2024
@winskuo-quic
Copy link
Collaborator Author

Hi @cccclai,
This PR is to use simple_evaluate for evaluation purposes since evaluate_model function has been removed.
Please have a look.
Thanks

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - we should set up some simple CI for quantized model, maybe at least 16a16w, so it can be caught early

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai cccclai merged commit 5b49bc6 into pytorch:main Oct 28, 2024
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants