-
Notifications
You must be signed in to change notification settings - Fork 606
[ET-VK] Enable custom rotary embedding module replacement #6393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context Implements a module replacement source transform to use the rotary embedding custom op introduced in the previous diff in the Llama model. Differential Revision: [D64697590](https://our.internmc.facebook.com/intern/diff/D64697590/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6393
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 03e21da with merge base 46ea1a4 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D64697590 |
This was referenced Oct 21, 2024
SS-JIA
added a commit
that referenced
this pull request
Oct 21, 2024
## Context Implements a module replacement source transform to use the rotary embedding custom op introduced in the previous diff in the Llama model. Differential Revision: [D64697590](https://our.internmc.facebook.com/intern/diff/D64697590/) ghstack-source-id: 249135618 Pull Request resolved: #6393
## Context Implements a module replacement source transform to use the rotary embedding custom op introduced in the previous diff in the Llama model. Differential Revision: [D64697590](https://our.internmc.facebook.com/intern/diff/D64697590/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D64697590 |
SS-JIA
added a commit
that referenced
this pull request
Oct 21, 2024
Pull Request resolved: #6393 ## Context Implements a module replacement source transform to use the rotary embedding custom op introduced in the previous diff in the Llama model. ghstack-source-id: 249175727 @exported-using-ghexport Differential Revision: [D64697590](https://our.internmc.facebook.com/intern/diff/D64697590/)
jorgep31415
approved these changes
Oct 21, 2024
kirklandsign
pushed a commit
that referenced
this pull request
Oct 21, 2024
Pull Request resolved: #6393 ## Context Implements a module replacement source transform to use the rotary embedding custom op introduced in the previous diff in the Llama model. ghstack-source-id: 249175727 @exported-using-ghexport Differential Revision: [D64697590](https://our.internmc.facebook.com/intern/diff/D64697590/)
kirklandsign
added a commit
that referenced
this pull request
Oct 21, 2024
Pull Request resolved: #6393 ## Context Implements a module replacement source transform to use the rotary embedding custom op introduced in the previous diff in the Llama model. ghstack-source-id: 249175727 @exported-using-ghexport Differential Revision: [D64697590](https://our.internmc.facebook.com/intern/diff/D64697590/) Co-authored-by: Stephen Jia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
Implements a module replacement source transform to use the rotary embedding custom op introduced in the previous diff in the Llama model.
Differential Revision: D64697590