Skip to content

[ET-VK] Enable custom rotary embedding module replacement #6393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Oct 21, 2024

Stack from ghstack (oldest at bottom):

Context

Implements a module replacement source transform to use the rotary embedding custom op introduced in the previous diff in the Llama model.

Differential Revision: D64697590

## Context

Implements a module replacement source transform to use the rotary embedding custom op introduced in the previous diff in the Llama model.

Differential Revision: [D64697590](https://our.internmc.facebook.com/intern/diff/D64697590/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Oct 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6393

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 03e21da with merge base 46ea1a4 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64697590

SS-JIA added a commit that referenced this pull request Oct 21, 2024
## Context

Implements a module replacement source transform to use the rotary embedding custom op introduced in the previous diff in the Llama model.

Differential Revision: [D64697590](https://our.internmc.facebook.com/intern/diff/D64697590/)

ghstack-source-id: 249135618
Pull Request resolved: #6393
## Context

Implements a module replacement source transform to use the rotary embedding custom op introduced in the previous diff in the Llama model.

Differential Revision: [D64697590](https://our.internmc.facebook.com/intern/diff/D64697590/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64697590

SS-JIA added a commit that referenced this pull request Oct 21, 2024
Pull Request resolved: #6393

## Context

Implements a module replacement source transform to use the rotary embedding custom op introduced in the previous diff in the Llama model.
ghstack-source-id: 249175727
@exported-using-ghexport

Differential Revision: [D64697590](https://our.internmc.facebook.com/intern/diff/D64697590/)
@kirklandsign kirklandsign merged commit 43c92b0 into gh/SS-JIA/121/base Oct 21, 2024
44 of 46 checks passed
@kirklandsign kirklandsign deleted the gh/SS-JIA/121/head branch October 21, 2024 23:54
kirklandsign pushed a commit that referenced this pull request Oct 21, 2024
Pull Request resolved: #6393

## Context

Implements a module replacement source transform to use the rotary embedding custom op introduced in the previous diff in the Llama model.
ghstack-source-id: 249175727
@exported-using-ghexport

Differential Revision: [D64697590](https://our.internmc.facebook.com/intern/diff/D64697590/)
kirklandsign added a commit that referenced this pull request Oct 21, 2024
Pull Request resolved: #6393

## Context

Implements a module replacement source transform to use the rotary embedding custom op introduced in the previous diff in the Llama model.
ghstack-source-id: 249175727
@exported-using-ghexport

Differential Revision: [D64697590](https://our.internmc.facebook.com/intern/diff/D64697590/)

Co-authored-by: Stephen Jia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants