Skip to content

Add transpose ops make convolutions channels-last. #6459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add transpose ops make convolutions channels-last. #6459

merged 1 commit into from
Oct 25, 2024

Conversation

hsharma35
Copy link
Contributor

Summary: Keeping this pass at opt_level=3 as this would introduce extra transpose ops.

Reviewed By: zonglinpeng

Differential Revision: D62484686

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6459

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ac73b60 with merge base 395b4d6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62484686

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Oct 23, 2024
@hsharma35 @facebook-github-bot
Fix conv1D and conv2D custom ops with channel last = True. (pytorch#6459
c919152 
)

Summary:

Fix shape meta kernel for conv1D/conv2D when channel_last=True.

Reviewed By: zonglinpeng

Differential Revision: D62484686
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62484686

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Oct 23, 2024
@hsharma35 @facebook-github-bot
Fix conv1D and conv2D custom ops with channel last = True. (pytorch#6459
8793f92 
)

Summary:

Fix shape meta kernel for conv1D/conv2D when channel_last=True.

Reviewed By: zonglinpeng

Differential Revision: D62484686
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62484686

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Oct 24, 2024
@hsharma35 @facebook-github-bot
Fix conv1D and conv2D custom ops with channel last = True. (pytorch#6459
97c4095 
)

Summary:

Fix shape meta kernel for conv1D/conv2D when channel_last=True.

Reviewed By: zonglinpeng

Differential Revision: D62484686
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62484686

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Oct 24, 2024
@hsharma35 @facebook-github-bot
Fix conv1D and conv2D custom ops with channel last = True. (pytorch#6459
7c54d06 
)

Summary:

Fix shape meta kernel for conv1D/conv2D when channel_last=True.

Reviewed By: zonglinpeng

Differential Revision: D62484686
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62484686

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Oct 24, 2024
@hsharma35 @facebook-github-bot
Fix conv1D and conv2D custom ops with channel last = True. (pytorch#6459
674b8b7 
)

Summary:

Fix shape meta kernel for conv1D/conv2D when channel_last=True.

Reviewed By: zonglinpeng

Differential Revision: D62484686
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62484686

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Oct 24, 2024
@hsharma35 @facebook-github-bot
Fix conv1D and conv2D custom ops with channel last = True. (pytorch#6459
a7d774a 
)

Summary:

Fix shape meta kernel for conv1D/conv2D when channel_last=True.

Reviewed By: zonglinpeng

Differential Revision: D62484686
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62484686

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Oct 24, 2024
@hsharma35 @facebook-github-bot
Fix conv1D and conv2D custom ops with channel last = True. (pytorch#6459
43a0c9c 
)

Summary:

Fix shape meta kernel for conv1D/conv2D when channel_last=True.

Reviewed By: zonglinpeng

Differential Revision: D62484686
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62484686

@hsharma35 @facebook-github-bot
Fix conv1D and conv2D custom ops with channel last = True. (pytorch#6459
ac73b60 
)

Summary:

Fix shape meta kernel for conv1D/conv2D when channel_last=True.

Reviewed By: zonglinpeng

Differential Revision: D62484686
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62484686

@facebook-github-bot facebook-github-bot merged commit e93ad5f into pytorch:main Oct 25, 2024
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zonglinpeng zonglinpeng zonglinpeng approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsharma35 @facebook-github-bot @zonglinpeng