Skip to content

Fix selective build codegen for sym primops #6484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

GregoryComer
Copy link
Member

Summary:
Build-time codegen for selective build fails for symint/symfloat/etc. prim ops, for example "executorch_prim::add.Scalar": ["v1"]. At appears that the codegen logic doesn't currently handle kernels with no dtypes.

This change was split from D63882723.

Differential Revision: D64883035

Copy link

pytorch-bot bot commented Oct 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6484

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Cancelled Job

As of commit 017a68c with merge base e2526cc (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 24, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64883035

GregoryComer added a commit to GregoryComer/executorch that referenced this pull request Oct 24, 2024
Summary:

Build-time codegen for selective build fails for symint/symfloat/etc. prim ops, for example `"executorch_prim::add.Scalar": ["v1"]`. At appears that the codegen logic doesn't currently handle kernels with no dtypes.

This change was split from D63882723.

Reviewed By: Olivia-liu

Differential Revision: D64883035
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64883035

Summary:

Build-time codegen for selective build fails for symint/symfloat/etc. prim ops, for example `"executorch_prim::add.Scalar": ["v1"]`. At appears that the codegen logic doesn't currently handle kernels with no dtypes.

This change was split from D63882723.

Reviewed By: Olivia-liu

Differential Revision: D64883035
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64883035

@facebook-github-bot facebook-github-bot merged commit 8477fa9 into pytorch:main Oct 24, 2024
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants