move rope related logic together #6560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, rope related code scatters around a few different places in `llama_transformer`. It makes it hard to make changes to rope related things. This PR moves all rope related logic into its own module. Differential Revision: [D65173598](https://our.internmc.facebook.com/intern/diff/D65173598/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6560
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f11cde5 with merge base b8fbc48 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65173598 |
This was referenced Oct 29, 2024
Merged
Right now, rope related code scatters around a few different places in `llama_transformer`. It makes it hard to make changes to rope related things. This PR moves all rope related logic into its own module. Differential Revision: [D65173598](https://our.internmc.facebook.com/intern/diff/D65173598/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65173598 |
Right now, rope related code scatters around a few different places in `llama_transformer`. It makes it hard to make changes to rope related things. This PR moves all rope related logic into its own module. Differential Revision: [D65173598](https://our.internmc.facebook.com/intern/diff/D65173598/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65173598 |
This was referenced Nov 7, 2024
Right now, rope related code scatters around a few different places in `llama_transformer`. It makes it hard to make changes to rope related things. This PR moves all rope related logic into its own module. Differential Revision: [D65173598](https://our.internmc.facebook.com/intern/diff/D65173598/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65173598 |
Right now, rope related code scatters around a few different places in `llama_transformer`. It makes it hard to make changes to rope related things. This PR moves all rope related logic into its own module. Differential Revision: [D65173598](https://our.internmc.facebook.com/intern/diff/D65173598/) [ghstack-poisoned]
This was referenced Nov 17, 2024
|
This pull request was exported from Phabricator. Differential Revision: D65173598 |
Right now, rope related code scatters around a few different places in `llama_transformer`. It makes it hard to make changes to rope related things. This PR moves all rope related logic into its own module. Differential Revision: [D65173598](https://our.internmc.facebook.com/intern/diff/D65173598/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65173598 |
This was referenced Nov 22, 2024
Right now, rope related code scatters around a few different places in `llama_transformer`. It makes it hard to make changes to rope related things. This PR moves all rope related logic into its own module. Differential Revision: [D65173598](https://our.internmc.facebook.com/intern/diff/D65173598/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65173598 |
larryliu0820
approved these changes
Nov 27, 2024
|
@pytorchbot label "release notes: attention_sink" |
|
Didn't find following labels among repository labels: release notes: attention_sink |
facebook-github-bot
merged commit 318f65e
into
gh/helunwencser/68/base
41 of 44 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Nov 27, 2024
Pull Request resolved: #6560 Right now, rope related code scatters around a few different places in `llama_transformer`. It makes it hard to make changes to rope related things. This PR moves all rope related logic into its own module. ghstack-source-id: 255543205 Differential Revision: [D65173598](https://our.internmc.facebook.com/intern/diff/D65173598/) Co-authored-by: Lunwen He <[email protected]>
mergennachin
pushed a commit
that referenced
this pull request
Dec 2, 2024
Pull Request resolved: #6560 Right now, rope related code scatters around a few different places in `llama_transformer`. It makes it hard to make changes to rope related things. This PR moves all rope related logic into its own module. ghstack-source-id: 255543205 Differential Revision: [D65173598](https://our.internmc.facebook.com/intern/diff/D65173598/) Co-authored-by: Lunwen He <[email protected]>
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#6560 Right now, rope related code scatters around a few different places in `llama_transformer`. It makes it hard to make changes to rope related things. This PR moves all rope related logic into its own module. ghstack-source-id: 254019781 Differential Revision: [D65173598](https://our.internmc.facebook.com/intern/diff/D65173598/)
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Right now, rope related code scatters around a few different places in `llama_transformer`. It makes it hard to make changes to rope related things. This PR moves all rope related logic into its own module. Differential Revision: [D65173598](https://our.internmc.facebook.com/intern/diff/D65173598/) ghstack-source-id: 250785042 Pull Request resolved: pytorch/executorch#6560
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Right now, rope related code scatters around a few different places in
llama_transformer. It makes it hard to make changes to rope related things.This PR moves all rope related logic into its own module.
Differential Revision: D65173598